Add 'tag.gz' to extension filter for apps

igor.grzankowski · igor.grzankowski · commit 17c9e09f8512 · 2025-02-05T16:26:46.000+01:00
diff --git a/pkg/splunk/enterprise/util.go b/pkg/splunk/enterprise/util.go
@@ -1198,6 +1198,9 @@ func isAppExtentionValid(receivedKey string) bool {
 	case "tgz":
 		return true
 
+	case "tar.gz":
+		return true
+
 	default:
 		return false
 	}
diff --git a/pkg/splunk/enterprise/util_test.go b/pkg/splunk/enterprise/util_test.go
@@ -1176,7 +1176,7 @@ func TestGetAvailableDiskSpaceShouldFail(t *testing.T) {
 }
 
 func TestIsAppExtentionValid(t *testing.T) {
-	if !isAppExtentionValid("testapp.spl") || !isAppExtentionValid("testapp.tgz") {
+	if !isAppExtentionValid("testapp.spl") || !isAppExtentionValid("testapp.tgz") || !isAppExtentionValid("testapp.tar.gz") {
 		t.Errorf("failed to detect valid app extension")
 	}
 
diff --git a/test/testenv/appframework_utils.go b/test/testenv/appframework_utils.go
@@ -53,7 +53,7 @@ var AppInfo = map[string]map[string]string{
 	"100mb-app-12":                      {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-12.tgz"},
 	"100mb-app-13":                      {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-13.tgz"},
 	"100mb-app-14":                      {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-14.tgz"},
-	"100mb-app-15":                      {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-15.tgz"},
+	"100mb-app-15":                      {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-15.tar.gz"},
 }
 
 // AppSourceInfo holds info related to app sources

Original file line number	Diff line number	Diff line change
`@@ -1198,6 +1198,9 @@ func isAppExtentionValid(receivedKey string) bool {`
`1198`	`1198`	`case "tgz":`
`1199`	`1199`	`return true`
`1200`	`1200`
	`1201`	`+ case "tar.gz":`
	`1202`	`+ return true`
	`1203`	`+`
`1201`	`1204`	`default:`
`1202`	`1205`	`return false`
`1203`	`1206`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1176,7 +1176,7 @@ func TestGetAvailableDiskSpaceShouldFail(t *testing.T) {`
`1176`	`1176`	`}`
`1177`	`1177`
`1178`	`1178`	`func TestIsAppExtentionValid(t *testing.T) {`
`1179`		`- if !isAppExtentionValid("testapp.spl") \|\| !isAppExtentionValid("testapp.tgz") {`
	`1179`	`+ if !isAppExtentionValid("testapp.spl") \|\| !isAppExtentionValid("testapp.tgz") \|\| !isAppExtentionValid("testapp.tar.gz") {`
`1180`	`1180`	`t.Errorf("failed to detect valid app extension")`
`1181`	`1181`	`}`
`1182`	`1182`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ var AppInfo = map[string]map[string]string{`
`53`	`53`	`"100mb-app-12": {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-12.tgz"},`
`54`	`54`	`"100mb-app-13": {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-13.tgz"},`
`55`	`55`	`"100mb-app-14": {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-14.tgz"},`
`56`		`- "100mb-app-15": {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-15.tgz"},`
	`56`	`+ "100mb-app-15": {"V1": "1.0.0", "V2": "1.0.0", "filename": "100mb-app-15.tar.gz"},`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`// AppSourceInfo holds info related to app sources`