Merge pull request #1452 from splunk/CSPL-3426

CSPL-3426: Support tar.gz extension for apps

Author: Igor-splunk

pkg/splunk/enterprise/util.go

@@ -1243,21 +1243,14 @@ func handleAppRepoChanges(ctx context.Context, client splcommon.ControllerClient
 
 // isAppExtentionValid checks if an app extention is supported or not
 func isAppExtentionValid(receivedKey string) bool {
-	appExtIdx := strings.LastIndex(receivedKey, ".")
-	if appExtIdx < 0 {
-		return false
-	}
-
-	switch appExt := receivedKey[appExtIdx+1:]; appExt {
-	case "spl":
-		return true
-
-	case "tgz":
-		return true
+	validExtensions := []string{".spl", ".tgz", ".tar.gz"}
 
-	default:
-		return false
+	for _, ext := range validExtensions {
+		if strings.HasSuffix(receivedKey, ext) {
+			return true
+		}
 	}
+	return false
 }
 
 // AddOrUpdateAppSrcDeploymentInfoList  modifies the App deployment status as perceived from the remote object listing

pkg/splunk/enterprise/util_test.go

@@ -1214,7 +1214,7 @@ func TestGetAvailableDiskSpaceShouldFail(t *testing.T) {
 }
 
 func TestIsAppExtentionValid(t *testing.T) {
-	if !isAppExtentionValid("testapp.spl") || !isAppExtentionValid("testapp.tgz") {
+	if !isAppExtentionValid("testapp.spl") || !isAppExtentionValid("testapp.tgz") || !isAppExtentionValid("testapp.tar.gz") {
 		t.Errorf("failed to detect valid app extension")
 	}