Skip to content

Commit 396c5cf

Browse files
committed
review comments
Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>
1 parent a9cc254 commit 396c5cf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/deploy-eks-cluster.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ function deleteCluster() {
3434
oidc_id=$(aws eks describe-cluster --name ${TEST_CLUSTER_NAME} --query "cluster.identity.oidc.issuer" --output text | cut -d '/' -f 5)
3535
aws iam delete-open-id-connect-provider --open-id-connect-provider-arn arn:aws:iam::${account_id}:oidc-provider/oidc.eks.us-west-2.amazonaws.com/id/${oidc_id}
3636
security_group_id=$(aws eks describe-cluster --name ${TEST_CLUSTER_NAME} --query "cluster.resourcesVpcConfig.securityGroupIds[0]" --output text)
37-
aws ec2 delete-security-group --group-id ${security_group_id}
3837
echo "Cleanup remaining PVC on the EKS Cluster ${TEST_CLUSTER_NAME}"
3938

4039
echo "Cleanup remaining PVC on the EKS Cluster ${TEST_CLUSTER_NAME}"
@@ -51,6 +50,7 @@ function deleteCluster() {
5150
echo "Unable to delete cluster - ${TEST_CLUSTER_NAME}"
5251
return 1
5352
fi
53+
aws ec2 delete-security-group --group-id ${security_group_id}
5454

5555
return 0
5656
}

0 commit comments

Comments
 (0)