Skip to content

Commit 6345e6c

Browse files
committed
CSPL-4022 Remove pipeline config from inputs
1 parent 9fbcb4a commit 6345e6c

33 files changed

+163
-651
lines changed

api/v4/indexercluster_types.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ const (
3838
type IndexerClusterSpec struct {
3939
CommonSplunkSpec `json:",inline"`
4040

41-
PipelineConfig PipelineConfigSpec `json:"pipelineConfig,omitempty"`
42-
4341
PullBus PushBusSpec `json:"pullBus,omitempty"`
4442

4543
// Number of search head pods; a search head cluster will be created if > 1
@@ -113,9 +111,6 @@ type IndexerClusterStatus struct {
113111
// status of each indexer cluster peer
114112
Peers []IndexerClusterMemberStatus `json:"peers"`
115113

116-
// Pipeline configuration status
117-
PipelineConfig PipelineConfigSpec `json:"pipelineConfig,omitempty"`
118-
119114
// Pull Bus status
120115
PullBus PushBusSpec `json:"pullBus,omitempty"`
121116

api/v4/ingestorcluster_types.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ type IngestorClusterSpec struct {
4444

4545
// Push Bus spec
4646
PushBus PushBusSpec `json:"pushBus"`
47-
48-
// Pipeline configuration
49-
PipelineConfig PipelineConfigSpec `json:"pipelineConfig"`
5047
}
5148

5249
// Helper types
@@ -79,20 +76,6 @@ type SQSSpec struct {
7976
EncodingFormat string `json:"encodingFormat"`
8077
}
8178

82-
type PipelineConfigSpec struct {
83-
RemoteQueueRuleset bool `json:"remoteQueueRuleset"`
84-
85-
RuleSet bool `json:"ruleSet"`
86-
87-
RemoteQueueTyping bool `json:"remoteQueueTyping"`
88-
89-
RemoteQueueOutput bool `json:"remoteQueueOutput"`
90-
91-
Typing bool `json:"typing"`
92-
93-
IndexerPipe bool `json:"indexerPipe"`
94-
}
95-
9679
// IngestorClusterStatus defines the observed state of Ingestor Cluster
9780
type IngestorClusterStatus struct {
9881
// Phase of the ingestor pods
@@ -119,9 +102,6 @@ type IngestorClusterStatus struct {
119102
// Auxillary message describing CR status
120103
Message string `json:"message"`
121104

122-
// Pipeline configuration status
123-
PipelineConfig PipelineConfigSpec `json:"pipelineConfig"`
124-
125105
// Push Bus status
126106
PushBus PushBusSpec `json:"pushBus"`
127107
}

api/v4/zz_generated.deepcopy.go

Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,11 @@ func main() {
110110
// as certificates issued by a trusted Certificate Authority (CA). The primary risk is potentially allowing
111111
// unauthorized access to sensitive metrics data. Consider replacing with CertDir, CertName, and KeyName
112112
// to provide certificates, ensuring the server communicates using trusted and secure certificates.
113-
TLSOpts: tlsOpts,
113+
TLSOpts: tlsOpts,
114114
FilterProvider: filters.WithAuthenticationAndAuthorization,
115115
}
116116

117-
// TODO: enable https for /metrics endpoint by default
117+
// TODO: enable https for /metrics endpoint by default
118118
// if secureMetrics {
119119
// // FilterProvider is used to protect the metrics endpoint with authn/authz.
120120
// // These configurations ensure that only authorized users and service accounts

config/crd/bases/enterprise.splunk.com_indexerclusters.yaml

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -5604,21 +5604,6 @@ spec:
56045604
type: string
56055605
type: object
56065606
x-kubernetes-map-type: atomic
5607-
pipelineConfig:
5608-
properties:
5609-
indexerPipe:
5610-
type: boolean
5611-
remoteQueueOutput:
5612-
type: boolean
5613-
remoteQueueRuleset:
5614-
type: boolean
5615-
remoteQueueTyping:
5616-
type: boolean
5617-
ruleSet:
5618-
type: boolean
5619-
typing:
5620-
type: boolean
5621-
type: object
56225607
pullBus:
56235608
description: |-
56245609
Helper types
@@ -8381,22 +8366,6 @@ spec:
83818366
- Terminating
83828367
- Error
83838368
type: string
8384-
pipelineConfig:
8385-
description: Pipeline configuration status
8386-
properties:
8387-
indexerPipe:
8388-
type: boolean
8389-
remoteQueueOutput:
8390-
type: boolean
8391-
remoteQueueRuleset:
8392-
type: boolean
8393-
remoteQueueTyping:
8394-
type: boolean
8395-
ruleSet:
8396-
type: boolean
8397-
typing:
8398-
type: boolean
8399-
type: object
84008369
pullBus:
84018370
description: Pull Bus status
84028371
properties:

config/crd/bases/enterprise.splunk.com_ingestorclusters.yaml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,22 +1580,6 @@ spec:
15801580
type: string
15811581
type: object
15821582
x-kubernetes-map-type: atomic
1583-
pipelineConfig:
1584-
description: Pipeline configuration
1585-
properties:
1586-
indexerPipe:
1587-
type: boolean
1588-
remoteQueueOutput:
1589-
type: boolean
1590-
remoteQueueRuleset:
1591-
type: boolean
1592-
remoteQueueTyping:
1593-
type: boolean
1594-
ruleSet:
1595-
type: boolean
1596-
typing:
1597-
type: boolean
1598-
type: object
15991583
pushBus:
16001584
description: Push Bus spec
16011585
properties:
@@ -4561,22 +4545,6 @@ spec:
45614545
- Terminating
45624546
- Error
45634547
type: string
4564-
pipelineConfig:
4565-
description: Pipeline configuration status
4566-
properties:
4567-
indexerPipe:
4568-
type: boolean
4569-
remoteQueueOutput:
4570-
type: boolean
4571-
remoteQueueRuleset:
4572-
type: boolean
4573-
remoteQueueTyping:
4574-
type: boolean
4575-
ruleSet:
4576-
type: boolean
4577-
typing:
4578-
type: boolean
4579-
type: object
45804548
pushBus:
45814549
description: Push Bus status
45824550
properties:

docs/IndexIngestionSeparation.md

Lines changed: 6 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ In addition to common spec inputs, the IngestorCluster resource provides the fol
2525
| ---------- | ------- | ------------------------------------------------- |
2626
| replicas | integer | The number of replicas (defaults to 3) |
2727
| pushBus | PushBus | Message bus configuration for publishing messages (required) |
28-
| pipelineConfig | PipelineConfig | Configuration for pipeline (required) |
2928

3029
PushBus inputs can be found in the table below. As of now, only SQS type of message bus is supported.
3130

@@ -49,24 +48,13 @@ SQS message bus inputs can be found in the table below.
4948
| sendInterval | string | Send interval (e.g. 5s) |
5049
| encodingFormat | string | Encoding format (e.g. s2s) |
5150

52-
PipelineConfig inputs can be found in the table below.
53-
54-
| Key | Type | Description |
55-
| ---------- | ------- | ------------------------------------------------- |
56-
| remoteQueueRuleset | bool | Disable remote queue ruleset |
57-
| ruleSet | bool | Disable rule set |
58-
| remoteQueueTyping | bool | Disable remote queue typing |
59-
| remoteQueueOutput | bool | Disable remote queue output |
60-
| typing | bool | Disable typing |
61-
| indexerPipe | bool | Disable indexer pipe |
62-
6351
## Example
6452

65-
The example presented below configures IngestorCluster named ingestor with Splunk 9.4.4 image that resides in a default namespace and is scaled to 3 replicas that serve the ingestion traffic. This IngestorCluster custom resource is set up with the service account named ingestion-role-sa allowing it to perform SQS and S3 operations. Push Bus and Pipeline Config inputs allow the user to specify queue and bucket settings for the ingestion process.
53+
The example presented below configures IngestorCluster named ingestor with Splunk 9.4.4 image that resides in a default namespace and is scaled to 3 replicas that serve the ingestion traffic. This IngestorCluster custom resource is set up with the service account named ingestion-role-sa allowing it to perform SQS and S3 operations. Push Bus inputs allow the user to specify queue and bucket settings for the ingestion process.
6654

67-
In this case, it is the SQS and S3 based configuration where the messages are stored in sqs-test queue in us-west-2 region with dead letter queue set to sqs-dlq-test queue. The large message store is set to ingestion bucket in smartbus-test directory. Retry policy is set to max count with max retries per part equal to 4 and send interval set to 5 seconds. Pipeline config either enables (false) or disables (true) settings such as remote queue ruleset, ruleset, remote quee typing, typing, remote queue output and indexer pipe. Based on these inputs, default-mode.conf and outputs.conf files are configured accordingly.
55+
In this case, it is the SQS and S3 based configuration where the messages are stored in sqs-test queue in us-west-2 region with dead letter queue set to sqs-dlq-test queue. The large message store is set to ingestion bucket in smartbus-test directory. Retry policy is set to max count with max retries per part equal to 4 and send interval set to 5 seconds. Based on these inputs, default-mode.conf and outputs.conf files are configured accordingly.
6856

69-
Change of any of the pushBus or pipelineConfig inputs does not restart Splunk. It just updates the config values with no disruptions.
57+
Change of any of the pushBus inputs does not restart Splunk. It just updates the config values with no disruptions.
7058

7159
```
7260
apiVersion: enterprise.splunk.com/v4
@@ -92,13 +80,6 @@ spec:
9280
retryPolicy: max_count
9381
sendInterval: 5s
9482
encodingFormat: s2s
95-
pipelineConfig:
96-
remoteQueueRuleset: false
97-
ruleSet: true
98-
remoteQueueTyping: false
99-
remoteQueueOutput: false
100-
typing: true
101-
indexerPipe: true
10283
```
10384

10485
# IndexerCluster
@@ -113,7 +94,6 @@ In addition to common spec inputs, the IndexerCluster resource provides the foll
11394
| ---------- | ------- | ------------------------------------------------- |
11495
| replicas | integer | The number of replicas (defaults to 3) |
11596
| pullBus | PushBus | Message bus configuration for pulling messages (required) |
116-
| pipelineConfig | PipelineConfig | Configuration for pipeline (required) |
11797

11898
PullBus inputs can be found in the table below. As of now, only SQS type of message bus is supported.
11999

@@ -137,24 +117,13 @@ SQS message bus inputs can be found in the table below.
137117
| sendInterval | string | Send interval (e.g. 5s) |
138118
| encodingFormat | string | Encoding format (e.g. s2s) |
139119

140-
PipelineConfig inputs can be found in the table below.
141-
142-
| Key | Type | Description |
143-
| ---------- | ------- | ------------------------------------------------- |
144-
| remoteQueueRuleset | bool | Disable remote queue ruleset |
145-
| ruleSet | bool | Disable rule set |
146-
| remoteQueueTyping | bool | Disable remote queue typing |
147-
| remoteQueueOutput | bool | Disable remote queue output |
148-
| typing | bool | Disable typing |
149-
| indexerPipe | bool | Disable indexer pipe |
150-
151120
## Example
152121

153-
The example presented below configures IndexerCluster named indexer with Splunk 9.4.4 image that resides in a default namespace and is scaled to 3 replicas that serve the indexing traffic. This IndexerCluster custom resource is set up with the service account named ingestion-role-sa allowing it to perform SQS and S3 operations. Pull Bus and Pipeline Config inputs allow the user to specify queue and bucket settings for the indexing process.
122+
The example presented below configures IndexerCluster named indexer with Splunk 9.4.4 image that resides in a default namespace and is scaled to 3 replicas that serve the indexing traffic. This IndexerCluster custom resource is set up with the service account named ingestion-role-sa allowing it to perform SQS and S3 operations. Pull Bus inputs allow the user to specify queue and bucket settings for the indexing process.
154123

155-
In this case, it is the SQS and S3 based configuration where the messages are stored in and retrieved from sqs-test queue in us-west-2 region with dead letter queue set to sqs-dlq-test queue. The large message store is set to ingestion bucket in smartbus-test directory. Retry policy is set to max count with max retries per part equal to 4 and send interval set to 5 seconds. Pipeline config either enables (false) or disables (true) settings such as remote queue ruleset, ruleset, remote quee typing, typing and remote queue output. Based on these inputs, default-mode.conf, inputs.conf and outputs.conf files are configured accordingly.
124+
In this case, it is the SQS and S3 based configuration where the messages are stored in and retrieved from sqs-test queue in us-west-2 region with dead letter queue set to sqs-dlq-test queue. The large message store is set to ingestion bucket in smartbus-test directory. Retry policy is set to max count with max retries per part equal to 4 and send interval set to 5 seconds. Based on these inputs, default-mode.conf, inputs.conf and outputs.conf files are configured accordingly.
156125

157-
Change of any of the pullBus or pipelineConfig inputs does not restart Splunk. It just updates the config values with no disruptions.
126+
Change of any of the pullBus inputs does not restart Splunk. It just updates the config values with no disruptions.
158127

159128
```
160129
apiVersion: enterprise.splunk.com/v4
@@ -192,12 +161,6 @@ spec:
192161
retryPolicy: max_count
193162
sendInterval: 5s
194163
encodingFormat: s2s
195-
pipelineConfig:
196-
remoteQueueRuleset: false
197-
ruleSet: true
198-
remoteQueueTyping: false
199-
remoteQueueOutput: false
200-
typing: true
201164
```
202165

203166
# Common Spec
@@ -251,13 +214,6 @@ ingestorCluster:
251214
name: ingestor
252215
replicaCount: 3
253216
serviceAccount: ingestion-role-sa
254-
pipelineConfig:
255-
remoteQueueRuleset: false
256-
ruleSet: true
257-
remoteQueueTyping: false
258-
remoteQueueOutput: false
259-
typing: true
260-
indexerPipe: true
261217
pushBus:
262218
type: sqs_smartbus
263219
sqs:
@@ -287,13 +243,6 @@ indexerCluster:
287243
serviceAccount: ingestion-role-sa
288244
clusterManagerRef:
289245
name: cm
290-
pipelineConfig:
291-
remoteQueueRuleset: false
292-
ruleSet: true
293-
remoteQueueTyping: false
294-
remoteQueueOutput: false
295-
typing: true
296-
indexerPipe: true
297246
pullBus:
298247
type: sqs_smartbus
299248
sqs:
@@ -635,13 +584,6 @@ spec:
635584
retryPolicy: max_count
636585
sendInterval: 5s
637586
encodingFormat: s2s
638-
pipelineConfig:
639-
remoteQueueRuleset: false
640-
ruleSet: true
641-
remoteQueueTyping: false
642-
remoteQueueOutput: false
643-
typing: true
644-
indexerPipe: true
645587
```
646588

647589
```
@@ -671,13 +613,6 @@ Metadata:
671613
UID: 12345678-1234-1234-1234-1234567890123
672614
Spec:
673615
Image: splunk/splunk:9.4.4
674-
Pipeline Config:
675-
Indexer Pipe: true
676-
Remote Queue Output: false
677-
Remote Queue Ruleset: false
678-
Remote Queue Typing: false
679-
Rule Set: true
680-
Typing: true
681616
Push Bus:
682617
Sqs:
683618
Auth Region: us-west-2
@@ -796,12 +731,6 @@ spec:
796731
retryPolicy: max_count
797732
sendInterval: 5s
798733
encodingFormat: s2s
799-
pipelineConfig:
800-
remoteQueueRuleset: false
801-
ruleSet: true
802-
remoteQueueTyping: false
803-
remoteQueueOutput: false
804-
typing: true
805734
```
806735

807736
```

0 commit comments

Comments
 (0)