Merge pull request #1456 from splunk/bug/CSPL_3518_default_servicetype_overwritten

kasiakoziol · web-flow · commit cfd650cd1637 · 2025-03-12T08:28:17.000+01:00
CSPL-3518 Service Type default does not get overwritten if not set to ClusterIP
diff --git a/pkg/splunk/enterprise/configuration.go b/pkg/splunk/enterprise/configuration.go
@@ -326,10 +326,6 @@ func setServiceTemplateDefaults(spec *enterpriseApi.Spec) {
 			}
 		}
 	}
-
-	if spec.ServiceTemplate.Spec.Type == "" {
-		spec.ServiceTemplate.Spec.Type = corev1.ServiceTypeClusterIP
-	}
 }
 
 // validateCommonSplunkSpec checks validity and makes default updates to a CommonSplunkSpec, and returns error if something is wrong.

Original file line number	Diff line number	Diff line change
`@@ -326,10 +326,6 @@ func setServiceTemplateDefaults(spec *enterpriseApi.Spec) {`
`326`	`326`	`}`
`327`	`327`	`}`
`328`	`328`	`}`
`329`		`-`
`330`		`- if spec.ServiceTemplate.Spec.Type == "" {`
`331`		`- spec.ServiceTemplate.Spec.Type = corev1.ServiceTypeClusterIP`
`332`		`- }`
`333`	`329`	`}`
`334`	`330`
`335`	`331`	`// validateCommonSplunkSpec checks validity and makes default updates to a CommonSplunkSpec, and returns error if something is wrong.`