Added sanity checks on data

Author: edro15

appserver/static/visualizations/ohlc/package-lock.json

@@ -17,7 +17,6 @@
     "c3": "^0.6.6",
     "d3": "^5.5.0",
     "jquery": "^2.2.4",
-    "plotly": "^1.0.6",
     "plotly.js-dist": "^1.46.0",
     "regexp-replace-loader": "^1.0.1",
     "save": "^2.3.2",

appserver/static/visualizations/ohlc/package.json

@@ -64,21 +64,24 @@ define([
           return;
         }
 
-        //This checks if all data being passed in are numbers and displays an error if not.
-        // if (_.isNaN(data)) {
-        //   throw new SplunkVisualizationBase.VisualizationError(
-        //     'This chart only supports numbers'
-        //   );
-        // }
-
         var columns = data.columns,
             retData = {};
 
         $.each(data.fields, function(i, field){
             if (CURRENCY_PAIR_FIELDNAME === field.name.toLowerCase()) {
-                retData[field.name.toLowerCase()] = $.unique(columns[i])[0];
+                // Removing null values to avoid errors
+                var filtered = columns[i].filter(function (el) {
+                  return el != null;
+                });
+                retData[field.name.toLowerCase()] = $.unique(filtered)[0];
                 return true;
             }
+            // Raise if null values found
+            if ($.inArray(null, columns[i]) >= 0 && field.name.toLowerCase().indexOf("point") < 0) {
+              throw new SplunkVisualizationBase.VisualizationError(
+                'Null values for field "' + field.name + '" are not supported'
+              );
+            }
             retData[field.name.toLowerCase()] = columns[i];
         });
 

appserver/static/visualizations/ohlc/src/visualization_source.js

@@ -109,21 +109,24 @@ define(["api/SplunkVisualizationBase","api/SplunkVisualizationUtils"], function(
 	          return;
 	        }
 
-	        //This checks if all data being passed in are numbers and displays an error if not.
-	        // if (_.isNaN(data)) {
-	        //   throw new SplunkVisualizationBase.VisualizationError(
-	        //     'This chart only supports numbers'
-	        //   );
-	        // }
-
 	        var columns = data.columns,
 	            retData = {};
 
 	        $.each(data.fields, function(i, field){
 	            if (CURRENCY_PAIR_FIELDNAME === field.name.toLowerCase()) {
-	                retData[field.name.toLowerCase()] = $.unique(columns[i])[0];
+	                // Removing null values to avoid errors
+	                var filtered = columns[i].filter(function (el) {
+	                  return el != null;
+	                });
+	                retData[field.name.toLowerCase()] = $.unique(filtered)[0];
 	                return true;
 	            }
+	            // Raise if null values found
+	            if ($.inArray(null, columns[i]) >= 0 && field.name.toLowerCase().indexOf("point") < 0) {
+	              throw new SplunkVisualizationBase.VisualizationError(
+	                'Null values for field "' + field.name + '" are not supported'
+	              );
+	            }
 	            retData[field.name.toLowerCase()] = columns[i];
 	        });