Skip to content

Commit f0f44cd

Browse files
committed
[OHLC viz] Minor style changes to enhance dark mode viz
1 parent e86d0b2 commit f0f44cd

File tree

2 files changed

+204378
-204350
lines changed

2 files changed

+204378
-204350
lines changed

appserver/static/visualizations/ohlc/src/visualization_source.js

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ define([
2626
'decrease': '#FF0000',
2727
'increase': '#008000',
2828
'trendlines': {
29-
[EMA8_FIELDNAME]: '#0140AD',
29+
[EMA8_FIELDNAME]: '#2DB8BA',
3030
[EMA20_FIELDNAME]: '#FF8026',
3131
[SMA4_FIELDNAME]: '#9B1232'
3232
}
@@ -195,7 +195,7 @@ define([
195195
paper_bgcolor: isDarkTheme ? "transparent" : "#fff",
196196
plot_bgcolor: isDarkTheme ? "transparent" : "#fff",
197197
font: {
198-
color: isDarkTheme ? '#DCDCDC' : '#444',
198+
color: isDarkTheme ? '#A6A6A6' : '#444',
199199
},
200200
showlegend: dispLegend,
201201
// https://plot.ly/javascript/reference/#layout-legend
@@ -206,18 +206,34 @@ define([
206206
xaxis: {
207207
autorange: true,
208208
tickangle: xTickAngle,
209-
title: xAxisLabel,
209+
tickfont: {
210+
color: isDarkTheme ? "#A6A6A6" : "#444",
211+
},
212+
title: {
213+
text: xAxisLabel,
214+
font: {
215+
color: isDarkTheme ? "#A6A6A6" : "#444",
216+
},
217+
},
210218
rangeslider: {
211219
visible: rSlider
212220
},
213-
gridcolor: isDarkTheme ? "#A6A6A6" : "#eee",
221+
gridcolor: isDarkTheme ? "#949494" : "#eee",
214222
type: 'date'
215223
},
216224
yaxis: {
217225
autorange: true,
218-
gridcolor: isDarkTheme ? "#A6A6A6" : "#eee",
226+
gridcolor: isDarkTheme ? "#949494" : "#eee",
219227
tickangle: yTickAngle,
220-
title: yAxisLabel
228+
tickfont: {
229+
color: isDarkTheme ? "#A6A6A6" : "#444",
230+
},
231+
title: {
232+
text: yAxisLabel,
233+
font: {
234+
color: isDarkTheme ? "#A6A6A6" : "#444",
235+
},
236+
}
221237
}
222238
};
223239

@@ -244,8 +260,7 @@ define([
244260
line: {
245261
// Ref: https://plot.ly/javascript/reference/#ohlc
246262
dash: 'solid',
247-
color: COLORS.trendlines[name],
248-
width: 1
263+
color: COLORS.trendlines[name]
249264
}
250265
};
251266
},

0 commit comments

Comments
 (0)