Update HttpService.java

ashah-splunk · ashah-splunk · commit 7de566c5f6bd · 2023-01-06T18:15:54.000+05:30
updating SSL_SOCKET_FACTORY on changing validateCertificates flag.
diff --git a/splunk/src/main/java/com/splunk/HttpService.java b/splunk/src/main/java/com/splunk/HttpService.java
@@ -558,8 +558,12 @@ public static SSLSocketFactory getSSLSocketFactory() {
         return HttpService.sslSocketFactory;
     }
 
-    public static void setValidateCertificates(boolean validateCertificates) {
-        HttpService.validateCertificates = validateCertificates;
+    public static void setValidateCertificates(boolean validateCertificate) {
+        // update the SSL_SOCKET_FACTORY if validateCertificates flag is changed
+        if (validateCertificates != validateCertificate) {
+            validateCertificates = validateCertificate;
+            sslSocketFactory = createSSLFactory();
+        }
     }
 
     public static SSLSocketFactory createSSLFactory() {

Original file line number	Diff line number	Diff line change
`@@ -558,8 +558,12 @@ public static SSLSocketFactory getSSLSocketFactory() {`
`558`	`558`	`return HttpService.sslSocketFactory;`
`559`	`559`	`}`
`560`	`560`
`561`		`- public static void setValidateCertificates(boolean validateCertificates) {`
`562`		`- HttpService.validateCertificates = validateCertificates;`
	`561`	`+ public static void setValidateCertificates(boolean validateCertificate) {`
	`562`	`+ // update the SSL_SOCKET_FACTORY if validateCertificates flag is changed`
	`563`	`+ if (validateCertificates != validateCertificate) {`
	`564`	`+ validateCertificates = validateCertificate;`
	`565`	`+ sslSocketFactory = createSSLFactory();`
	`566`	`+ }`
`563`	`567`	`}`
`564`	`568`
`565`	`569`	`public static SSLSocketFactory createSSLFactory() {`