Skip to content

Commit 255830d

Browse files
committed
PR review adjustments
1 parent df67581 commit 255830d

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

README.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,12 @@ Using `pip` is the easiest way to pull the SDK into your project. `poetry` and `
3535
In your app's project folder:
3636

3737
```sh
38-
$ python -m venv .venv
39-
$ source .venv/bin/activate
40-
# Bundle all your dependencies into `bin/` before deploying!
41-
# Skip it if you're not building an app.
42-
# Use `splunk-sdk[compat]` if you encounter issues with `six` when deploying to Splunk.
43-
$ python -m pip install splunk-sdk --target bin/
38+
python -m venv .venv
39+
source .venv/bin/activate
40+
python -m pip install splunk-sdk --target bin/
4441
```
4542

43+
Install your dependencies into `bin/` if bundling with an app, otherwise you can skip it.
4644
[See docs](https://dev.splunk.com/enterprise/docs/developapps/createapps/appanatomy/) on more details about packaging additional dependencies with your app.
4745

4846
### Using SDK in apps
@@ -182,9 +180,9 @@ A file called `.env.template` exists in the root of this repository. Duplicate i
182180
183181
```sh
184182
# Run entire test suite:
185-
$ make test
183+
make test
186184
# Run only the unit tests:
187-
$ make test-unit
185+
make test-unit
188186
```
189187

190188
##### Integration tests
@@ -194,10 +192,10 @@ $ make test-unit
194192
```sh
195193
# This command starts a Splunk Docker container
196194
# and waits until it reaches an operational state.
197-
$ SPLUNK_VERSION=latest make docker-start
195+
SPLUNK_VERSION=latest make docker-start
198196

199197
# Run the integration tests:
200-
$ make test-integration
198+
make test-integration
201199
```
202200

203201
> Do not run the test suite against a production instance of Splunk! It will run just fine with the free Splunk license.

splunklib/binding.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,10 +1531,6 @@ def handler(key_file=None, cert_file=None, timeout=None, verify=False, context=N
15311531
:type context: ``SSLContext``
15321532
:param `timeout`: The request time-out period, in seconds (optional).
15331533
:type timeout: ``integer`` or "None"
1534-
:param `verify`: Set to False to disable SSL verification on https connections.
1535-
:type verify: ``Boolean``
1536-
:param `context`: The SSLContext that can is used with the HTTPSConnection when verify=True is enabled and context is specified
1537-
:type context: ``SSLContext``
15381534
"""
15391535

15401536
def connect(scheme, host, port):

0 commit comments

Comments
 (0)