Fixed __contains__ in Inputs (since it needs a special case).

It and __getitem__ on Inputs still need to be rewritten to avoid using list(). I've filed a Jira on myself for that (SPL-53341).

Author: Frederick Ross

splunklib/client.py

@@ -1461,6 +1461,13 @@ def __getitem__(self, key):
         else:
             raise KeyError(key)
 
+    def __contains__(self, key):
+        try:
+            self.__getitem__(key)
+            return True
+        except KeyError:
+            return False
+        
 
     def create(self, kind, name, **kwargs):
         """Creates an input of a specific kind in this collection, with any 

tests/test_input.py

@@ -109,9 +109,9 @@ def test_crud(self):
         for input in inputs:
             if input.name == '9999':
                 inputs.delete(input.kind, input.name)
-        self.assertFalse(inputs.contains('9999'))
+        self.assertFalse('9999' in inputs)
         inputs.create("tcp", "9999", host="sdk-test")
-        self.assertTrue(inputs.contains('9999'))
+        self.assertTrue('9999' in inputs)
         input_ = inputs['9999']
         self.assertEqual(input_.kind, "tcp")
         self.assertEqual(input_['host'], "sdk-test")
@@ -128,7 +128,8 @@ def test_crud(self):
         for input in inputs:
             if input.name == '9999':
                 inputs.delete(input.kind, input.name)
-        self.assertFalse(inputs.contains('9999'))
+        self.assertFalse('9999' in inputs)
+        self.assertFalse(inputs.contains('9999'));