Skip to content

Commit 4c94136

Browse files
committed
Review changes
Reverting the pseudo code punct, and making that list a bit nicer.
1 parent 4036581 commit 4c94136

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

splunklib/binding.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ def delete(self, path_segment, owner=None, app=None, sharing=None, **query):
498498
499499
c = binding.connect(...)
500500
c.delete('saved/searches/boris') == \\
501-
{'body': '...a response reader object...',
501+
{'body': ...a response reader object...,
502502
'headers': [('content-length', '1786'),
503503
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
504504
('server', 'Splunkd'),
@@ -556,7 +556,7 @@ def get(self, path_segment, owner=None, app=None, sharing=None, **query):
556556
557557
c = binding.connect(...)
558558
c.get('apps/local') == \\
559-
{'body': '...a response reader object...',
559+
{'body': ...a response reader object...,
560560
'headers': [('content-length', '26208'),
561561
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
562562
('server', 'Splunkd'),
@@ -622,7 +622,7 @@ def post(self, path_segment, owner=None, app=None, sharing=None, headers=[], **q
622622
c = binding.connect(...)
623623
c.post('saved/searches', name='boris',
624624
search='search * earliest=-1m | head 1') == \\
625-
{'body': '...a response reader object...',
625+
{'body': ...a response reader object...,
626626
'headers': [('content-length', '10455'),
627627
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
628628
('server', 'Splunkd'),
@@ -687,7 +687,7 @@ def request(self, path_segment, method="GET", headers=[], body="",
687687
688688
c = binding.connect(...)
689689
c.request('saved/searches', method='GET') == \\
690-
{'body': '...a response reader object...',
690+
{'body': ...a response reader object...,
691691
'headers': [('content-length', '46722'),
692692
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
693693
('server', 'Splunkd'),

splunklib/client.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ def get(self, path_segment="", owner=None, app=None, sharing=None, **query):
664664
s = client.service(...)
665665
apps = s.apps
666666
apps.get() == \\
667-
{'body': '...a response reader object...',
667+
{'body': ...a response reader object...,
668668
'headers': [('content-length', '26208'),
669669
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
670670
('server', 'Splunkd'),
@@ -727,7 +727,7 @@ def post(self, path_segment="", owner=None, app=None, sharing=None, **query):
727727
s = client.service(...)
728728
apps = s.apps
729729
apps.post(name='boris') == \\
730-
{'body': '...a response reader object...',
730+
{'body': ...a response reader object...,
731731
'headers': [('content-length', '2908'),
732732
('expires', 'Fri, 30 Oct 1998 00:00:00 GMT'),
733733
('server', 'Splunkd'),
@@ -2987,12 +2987,15 @@ def arguments(self):
29872987
29882988
The keys in the dictionary are the names of the arguments. The values are
29892989
another dictionary giving the metadata about that argument. The possible
2990-
keys in that dictionary are:
2991-
"title": A ``string``.
2992-
"description": A ``string``.
2993-
"required_on_create": A ``string`` that is "true" or "false".
2994-
"required_on_edit": A ``string`` that is "true" or "false".
2995-
"data_type": A ``string`` that is "boolean", "string", or "number".
2990+
keys in that dictionary are:
2991+
2992+
- "title" (``string``): The title of the input.
2993+
- "description" (``string``): The description.
2994+
- "required_on_create" (``string``): Indicates whether the parameter
2995+
is required for create ("true" or "false").
2996+
- "required_on_edit" (``string``): Indicates whether the parameter
2997+
is required for edit ("true" or "false").
2998+
- "data_type" (``string``): The data type ("boolean", "string", or "number").
29962999
29973000
:return: A ``dict`` of arguments that are supported by this modular input kind.
29983001
"""

0 commit comments

Comments
 (0)