Skip to content

Commit 5af3ae7

Browse files
author
Frederick Ross
committed
Added tearDownClass method to delete all test suite-created apps.
Made opts and service in test lib into class fields so that they can be used by tearDownClass.
1 parent c5aa3d6 commit 5af3ae7

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

tests/test_app.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,17 @@ def setUp(self):
3939
else:
4040
logging.debug("App %s already exists. Skipping creation.", self.app_name)
4141

42-
class TestAppIntegrity(TestApp):
42+
@classmethod
43+
def tearDownClass(cls):
44+
for app in cls.service.apps:
45+
if app.name.startswith('delete-me'):
46+
cls.service.apps.delete(app.name)
47+
4348
def test_app_integrity(self):
4449
self.check_entity(self.app)
4550
self.app.setupInfo
4651
self.app['setupInfo']
4752

48-
class TestDisableEnable(TestApp):
4953
def test_disable_enable(self):
5054
self.app.disable()
5155
self.app.refresh()
@@ -54,7 +58,6 @@ def test_disable_enable(self):
5458
self.app.refresh()
5559
self.assertEqual(self.app['disabled'], '0')
5660

57-
class TestUpdate(TestApp):
5861
def test_update(self):
5962
kwargs = {
6063
'author': "Me",
@@ -70,22 +73,19 @@ def test_update(self):
7073
self.assertEqual(self.app['manageable'], "0")
7174
self.assertEqual(self.app['visible'], "1")
7275

73-
class TestDelete(TestApp):
7476
def test_delete(self):
7577
name = testlib.tmpname()
7678
app = self.service.apps.create(name)
7779
self.assertTrue(name in self.service.apps)
7880
self.service.apps.delete(name)
7981
self.assertFalse(name in self.service.apps)
8082

81-
class TestPackage(TestApp):
8283
def test_package(self):
8384
p = self.app.package()
8485
self.assertEqual(p.name, self.app_name)
8586
self.assertTrue(p.path.endswith(self.app_name + '.spl'))
8687
self.assertTrue(p.url.endswith(self.app_name + '.spl'))
8788

88-
class TestUpdateInfo(TestApp):
8989
def test_updateInfo(self):
9090
p = self.app.updateInfo()
9191
self.assertTrue(p is not None)

tests/testlib.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,16 +161,20 @@ def f(_):
161161
wait(None, f, timeout)
162162
self.assertEqual(fa(), fb())
163163

164-
service = None
165-
splunk_version = None
164+
@classmethod
165+
def setUpClass(cls):
166+
cls.opts = parse([], {}, ".splunkrc")
167+
import splunklib.client as client
168+
cls.service = client.connect(**cls.opts.kwargs)
166169

167170
def setUp(self):
168171
unittest.TestCase.setUp(self)
169172
import splunklib.client as client
170173
self.opts = parse([], {}, ".splunkrc")
171174
self.service = client.connect(**self.opts.kwargs)
172175
self.splunk_version = int(self.service.info['version'].split('.')[0])
173-
logging.debug("Connected to splunkd version %d", self.splunk_version)
176+
logging.debug("Connected to splunkd version %s", '.'.join(str(x) for x in self.service.splunk_version))
177+
174178

175179
def main():
176180
unittest.main()

0 commit comments

Comments
 (0)