Skip to content

Commit 8b6caac

Browse files
author
Frederick Ross
committed
Resolve Andrea's doc queries.
1 parent 4b2e72b commit 8b6caac

File tree

1 file changed

+39
-26
lines changed

1 file changed

+39
-26
lines changed

splunklib/client.py

Lines changed: 39 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,8 +1070,8 @@ def update(self, **kwargs):
10701070
:param kwargs: Additional entity-specific arguments (optional).
10711071
:type kwargs: ``dict``
10721072
1073-
:return: #FRED?
1074-
:rtype:
1073+
:return: The entity this method is called on.
1074+
:rtype: class:`Entity`
10751075
"""
10761076
# The peculiarity in question: the REST API creates a new
10771077
# Entity if we pass name in the dictionary, instead of the
@@ -1794,17 +1794,15 @@ def attached_socket(self, *args, **kwargs):
17941794
automatically closed at the end of the ``with`` block, even if an
17951795
exception is raised in the block.
17961796
1797-
:param args: Additional arguments:
1798-
1799-
- "host" (``string``): The host value for events written to the stream.
1800-
1801-
- "source" (``string``): The source value for events written to the stream.
1802-
1803-
- "sourcetype" (``string``): The sourcetype value for events written to the stream.
1797+
:param host: The host value for events written to the stream.
1798+
:type host: ``string``
1799+
:param source: The source value for events written to the stream.
1800+
:type source: ``string``
1801+
:param sourcetype: The sourcetype value for events written to the
1802+
stream.
1803+
:type sourcetype: ``string``
18041804
1805-
:type args: ``dict``
1806-
:param kwargs: #FRED, what do you specify in **kwargs? or if the host/source/sourcetype go HERE, what goes in *args?
1807-
:type kwargs: ``dict``
1805+
:returns: Nothing.
18081806
18091807
**Example**::
18101808
@@ -1974,8 +1972,8 @@ def update(self, **kwargs):
19741972
available parameters, see `Input parameters <http://dev.splunk.com/view/SP-CAAAEE6#inputparams>`_ on Splunk Developer Portal.
19751973
:type kwargs: ``dict``
19761974
1977-
:return: #FRED?
1978-
:rtype:
1975+
:return: The input this method was called on.
1976+
:rtype: class:`Input`
19791977
"""
19801978
if self.kind not in ['tcp', 'splunktcp', 'tcp/raw', 'tcp/cooked']:
19811979
result = super(Input, self).update(**kwargs)
@@ -2212,7 +2210,7 @@ def itemmeta(self, kind):
22122210
:type kind: ``string``
22132211
22142212
:return: The metadata.
2215-
:rtype: #FRED--a ``dict`` or ``record``?
2213+
:rtype: class:``splunklib.data.Record``
22162214
"""
22172215
response = self.get("%s/_new" % self._kindmap[kind])
22182216
content = _load_atom(response, MATCH_ENTRY_CONTENT)
@@ -2879,7 +2877,11 @@ def export(self, query, **params):
28792877
raise
28802878

28812879
def itemmeta(self):
2882-
""" #FRED DOC ME
2880+
"""There is no metadata available for class:``Jobs``.
2881+
2882+
Any call to this method raises a class:``NotSupportedError``.
2883+
2884+
:raises: class:``NotSupportedError``
28832885
"""
28842886
raise NotSupportedError()
28852887

@@ -2944,9 +2946,13 @@ def __init__(self, service):
29442946
Collection.__init__(self, service, PATH_LOGGER)
29452947

29462948
def itemmeta(self):
2947-
""" #FRED DOC ME
2949+
"""There is no metadata available for class:``Jobs``.
2950+
2951+
Any call to this method raises a class:``NotSupportedError``.
2952+
2953+
:raises: class:``NotSupportedError``
29482954
"""
2949-
raise NotSupportedError
2955+
raise NotSupportedError()
29502956

29512957
class Message(Entity):
29522958
def __init__(self, service, path, **kwargs):
@@ -2980,10 +2986,17 @@ def __getitem__(self, name):
29802986

29812987
@property
29822988
def arguments(self):
2983-
""" #FRED DOC ME
2984-
2985-
:return:
2986-
:rtype:
2989+
"""A dictionary of all the arguments supported by this modular input kind.
2990+
2991+
The keys in the dictionary are the names of the arguments. The values are
2992+
another dictionary giving the metadata about that argument. The possible
2993+
keys in that dictionary are ``"title"``, ``"description"``, ``"required_on_create``",
2994+
``"required_on_edit"``, ``"data_type"``. Each value is a string. It should be one
2995+
of ``"true"`` or ``"false"`` for ``"required_on_create"`` and ``"required_on_edit"``,
2996+
and one of ``"boolean"``, ``"string"``, or ``"number``" for ``"data_type"``.
2997+
2998+
:return: A dictionary describing the arguments this modular input kind takes.
2999+
:rtype: ``dict``
29873000
"""
29883001
return self.state.content['endpoint']['args']
29893002

@@ -3240,7 +3253,7 @@ def create(self, username, password, roles, **params):
32403253
:type params: ``dict``
32413254
32423255
:return: The new user.
3243-
:rtype: :class:`Entity` #FRED, not :class:`User`?
3256+
:rtype: :class:`User`
32443257
32453258
**Example**::
32463259
@@ -3272,7 +3285,7 @@ def delete(self, name):
32723285
:type name: ``string``
32733286
32743287
:return:
3275-
:rtype: :class:`Collection` #FRED, not :class:`Users`?
3288+
:rtype: :class:`Users`
32763289
"""
32773290
return Collection.delete(self, name.lower())
32783291

@@ -3377,7 +3390,7 @@ def create(self, name, **params):
33773390
:type params: ``dict``
33783391
33793392
:return: The new role.
3380-
:rtype: :class:`Entity` #FRED why not :class:`Role`?
3393+
:rtype: :class:`Role`
33813394
33823395
**Example**::
33833396
@@ -3407,7 +3420,7 @@ def delete(self, name):
34073420
:param name: The name of the role to delete.
34083421
:type name: ``string``
34093422
3410-
:rtype: The :class:`Collection` of roles #FRED not :class:`Roles`?
3423+
:rtype: The :class:`Roles`
34113424
"""
34123425

34133426
return Collection.delete(self, name.lower())

0 commit comments

Comments
 (0)