Improved TestSearchCommandsApp.test_command_parser

Author: David Noble

examples/saved_searches.py

@@ -27,6 +27,7 @@
     raise Exception("Add the SDK repository to your PYTHONPATH to run the examples "
                     "(e.g., export PYTHONPATH=~/splunk-sdk-python.")
 
+
 def main():
     opts = parse(sys.argv[1:], {}, ".splunkrc")
     service = connect(**opts.kwargs)

tests/test_searchcommands_app.py

@@ -217,8 +217,6 @@ def test_command_parser(self):
         encoder = JSONEncoder()
         file_path = TestSearchCommandsApp._data_file(os.path.join('input', 'counts.csv'))
 
-        command = StubbedStreamingCommand() # All options are required
-
         options = [
             'boolean=true',
             'duration=00:00:10',
@@ -228,9 +226,9 @@ def test_command_parser(self):
             'optionname=foo_bar',
             'regularexpression="\\\\w+"',
             'set=foo']
-
         fields = ['field_1', 'field_2', 'field_3']
 
+        command = StubbedStreamingCommand()  # All options are required
         parser.parse(options + fields, command)
         command_line = str(command)
 
@@ -239,8 +237,36 @@ def test_command_parser(self):
             command_line)
 
         for option in options:
-            self.assertRaises(ValueError, parser.parse([x for x in options if x != option] + ['field_1', 'field_2', 'field_3'], command))
+            self.assertRaises(ValueError, parser.parse, [x for x in options if x != option] + ['field_1', 'field_2', 'field_3'], command)
+
+        command = StubbedReportingCommand()  # No options are required
+        parser.parse(options + fields, command)
+
+        for option in options:
+            try:
+                parser.parse([x for x in options if x != option] + ['field_1', 'field_2', 'field_3'], command)
+            except Exception as e:
+                self.assertFalse("Unexpected exception: %s" % e)
+
+        try:
+            parser.parse(options, command)
+        except Exception as e:
+            self.assertFalse("Unexpected exception: %s" % e)
+
+        for option in command.options.itervalues():
+            self.assertTrue(option.is_set)
+
+        self.assertEqual(len(command.fieldnames), 0)
+
+        try:
+            parser.parse(fields, command)
+        except Exception as e:
+            self.assertFalse("Unexpected exception: %s" % e)
+
+        for option in command.options.itervalues():
+            self.assertFalse(option.is_set)
 
+        self.assertListEqual(fields, command.fieldnames)
         return
 
     def disable_test_option_logging_configuration(self):