Skip to content

Commit 948e47a

Browse files
committed
Integrate code review comments from Fred.
1 parent 25c28b6 commit 948e47a

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

splunklib/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2138,7 +2138,7 @@ def _get_kind_list(self, subpath=None):
21382138
content = _load_atom_entries(response)
21392139
for entry in content:
21402140
this_subpath = subpath + [entry.title]
2141-
# The "all" endpoint is not a real input collection.
2141+
# The "all" endpoint doesn't work yet.
21422142
# The "tcp/ssl" endpoint is not a real input collection.
21432143
if entry.title == 'all' or this_subpath == ['tcp','ssl']:
21442144
continue

tests/test_service.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,7 @@ def test_splunk_version(self):
109109

110110
def test_query_without_login(self):
111111
service = Service()
112-
try:
113-
service.splunk_version
114-
self.fail('Expected AuthenticationError.')
115-
except AuthenticationError:
116-
# Good
117-
pass
112+
self.assertRaises(AuthenticationError, lambda: service.splunk_version)
118113

119114
class TestSettings(testlib.SDKTestCase):
120115
def test_read_settings(self):

0 commit comments

Comments
 (0)