Quick fix for Search Commands demo for Guido tomorrow

Author: David Noble

examples/searchcommands_app/default/commands.conf

@@ -1,12 +1,14 @@
 # [commands.conf]($SPLUNK_HOME/etc/system/README/commands.conf.spec)
 [defaults]
-supports_getinfo = true
 
 [countmatches]
 filename = countmatches.py
+supports_getinfo = true
 
 [simulate]
 filename = simulate.py
+supports_getinfo = true
 
 [sum]
 filename = sum.py
+supports_getinfo = true

setup.py

@@ -145,13 +145,14 @@ def run(self):
         arc_app_lib_dir = os.path.join(arc_app_dir, 'bin', 'splunklib', 'searchcommands')
 
         def exclude(path):
+            # TODO: Replace with filter function because exclude is deprecated
             basename = os.path.basename(path)
             for pattern in ['.DS_Store', '.idea', '*.log', '*.py[co]']:
                 if fnmatch(basename, pattern):
-                    return False
-            return True
+                    return True
+            return False
 
-        with tarfile.open(tarball, "w") as spl:
+        with closing(tarfile.open(tarball, "w")) as spl:
             spl.add(app_dir, arcname=arc_app_dir, exclude=exclude)
             spl.add(lib_dir, arcname=arc_app_lib_dir, exclude=exclude)
 

splunklib/searchcommands/search_command.py

@@ -190,7 +190,7 @@ def process(self, args=argv, input_file=stdin, output_file=stdout):
                 'filename = %s' %
                 (type(self).name, path.basename(argv[0])))
             self.messages.append('error_message', message)
-            self.messages.write()
+            self.messages.write(output_file)
             self.logger.error(message)
 
     @staticmethod