testlib.SDKTestCase.teardown now ignores complaints about not being able to delete apps because these are likely spurious errors on Windows.

I've never hit this issue on Linux or OS X and this change eliminates
numerous false alarms on Windows.

Author: David Noble

examples/searchcommands_app/setup.py

@@ -207,11 +207,17 @@ def run(self):
         commands_conf = os.path.join(self.build_dir, 'default', 'commands.conf')
         source = os.path.join(self.build_dir, 'default', 'commands-scpv{}.conf'.format(self.scp_version))
 
-        if os.path.exists(commands_conf) or os.path.islink(commands_conf):
+        if os.path.exists(commands_conf) and os.path.islink(commands_conf):
             os.remove(commands_conf)
+        else:
+            try:
+                os.path.islink(commands_conf)
+            except OSError:
+                pass
+            else:
+                os.remove(commands_conf)
 
         os.symlink(source, commands_conf)
-
         self._make_archive()
         return
 

tests/data/custom_search/usercount.out

@@ -0,0 +1,10 @@
+Traceback (most recent call last):
+  File "custom_search/bin/usercount.py", line 182, in <module>
+    main(sys.argv)
+  File "custom_search/bin/usercount.py", line 149, in main
+    buf, settings = read_input(stdin_wrapper, has_header = True)
+  File "custom_search/bin/usercount.py", line 109, in read_input
+    line = buf.readline()
+  File "custom_search/bin/usercount.py", line 58, in readline
+    raise StopIteration
+StopIteration

tests/searchcommands/apps/app_with_logging_configuration/splunklib.log

@@ -0,0 +1,33 @@
+2015-09-21 17:55:28,246, Level=ERROR, Pid=1768, File=search_command.py, Line=962, RuntimeError at "../splunklib\searchcommands\search_command.py", line 601 : Command test appears to be statically configured for search command protocol version 1 and static configuration is unsupported by splunklib.searchcommands. Please ensure that default/commands.conf contains this stanza:
+[test]
+filename = test.py
+enableheader = true
+outputheader = true
+requires_srinfo = true
+supports_getinfo = true
+supports_multivalues = true
+supports_rawargs = true
+Traceback:
+  File "../splunklib\searchcommands\search_command.py", line 601, in _process_protocol_v1
+    raise RuntimeError(message)
+
+2015-09-21 17:55:28,253, Level=ERROR, Pid=1768, File=search_command.py, Line=962, RuntimeError at "C:\Users\Administrator\Workspace.private\splunk-sdks\splunk-sdk-python\tests\searchcommands\test_search_command.py", line 87 : Testing
+Traceback:
+  File "../splunklib\searchcommands\search_command.py", line 586, in _process_protocol_v1
+    self._execute(ifile, None)
+  File "../splunklib\searchcommands\streaming_command.py", line 54, in _execute
+    SearchCommand._execute(self, ifile, self.stream)
+  File "../splunklib\searchcommands\search_command.py", line 830, in _execute
+    self._record_writer.write_records(process(self._records(ifile)))
+  File "../splunklib\searchcommands\internals.py", line 515, in write_records
+    for record in records:
+  File "C:\Users\Administrator\Workspace.private\splunk-sdks\splunk-sdk-python\tests\searchcommands\test_search_command.py", line 87, in stream
+    raise RuntimeError('Testing')
+
+2015-09-21 17:55:28,256, Level=ERROR, Pid=1768, File=search_command.py, Line=962, RuntimeError at "../splunklib\searchcommands\search_command.py", line 864 : Failed to parse metadata of length 1382: Invalid \escape: line 1 column 186 (char 185)
+Traceback:
+  File "../splunklib\searchcommands\search_command.py", line 641, in _process_protocol_v2
+    metadata, body = self._read_chunk(ifile)
+  File "../splunklib\searchcommands\search_command.py", line 864, in _read_chunk
+    raise RuntimeError('Failed to parse metadata of length {}: {}'.format(metadata_length, error))
+

tests/testlib.py

@@ -246,7 +246,7 @@ def setUp(self):
         logging.debug("Connected to splunkd version %s", '.'.join(str(x) for x in self.service.splunk_version))
 
     def tearDown(self):
-        from urllib2 import HTTPError
+        from splunklib.binding import HTTPError
 
         if self.service.restart_required:
             self.fail("Test left Splunk in a state requiring a restart.")
@@ -255,10 +255,10 @@ def tearDown(self):
             if appName in self.service.apps:
                 try:
                     self.service.apps.delete(appName)
+                    wait(lambda: appName not in self.service.apps)
                 except HTTPError as error:
-                    print error
-                    pass
-                wait(lambda: appName not in self.service.apps)
-
+                    if error.status != 500:
+                        raise
+                    print 'Ignoring teardown error because it is likely spurious: {}'.format(error)
         if self.service.restart_required:
             self.clear_restart_message()