Skip to content

Commit a69667e

Browse files
author
David Noble
committed
Reconfigured examples to prevent logging message duplication
All handlers propagate by default. You must configure your loggers to prevent this. Signed-off-by: David Noble <[email protected]>
1 parent d88f761 commit a69667e

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

examples/searchcommands_app/default/logging.conf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,19 @@ handlers = stderr ; Default: stderr
99
qualname = CountMatchesCommand
1010
level = NOTSET ; Default: WARNING
1111
handlers = stderr ; Default: stderr
12+
propagate = 0 ; Default: 1
1213

1314
[logger_SimulateCommand]
1415
qualname = SimulateCommand
1516
level = NOTSET ; Default: WARNING
1617
handlers = stderr ; Default: stderr
18+
propagate = 0 ; Default: 1
1719

1820
[logger_SumCommand]
1921
qualname = SumCommand
2022
level = NOTSET ; Default: WARNING
2123
handlers = stderr ; Default: stderr
24+
propagate = 0 ; Default: 1
2225

2326
[handlers]
2427
keys=stderr

examples/searchcommands_template/default/logging.conf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ handlers = stderr ; Default: stderr
77

88
[logger_%(command.title())Command]
99
qualname = %(command.title())Command
10-
level = WARNING ; Default: WARNING
11-
handlers = stderr ; Default: stderr
10+
level = WARNING ; Default: WARNING
11+
handlers = stderr ; Default: stderr
12+
propagate = 0 ; Default: 1
1213

1314
[handlers]
1415
keys=stderr

splunklib/searchcommands/logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def configure(name, path=None):
108108
os.chdir(working_directory)
109109

110110
if len(root.handlers) == 0:
111-
root.addHandler(StreamHandler()) # shared by loggers without handlers
111+
root.addHandler(StreamHandler())
112112

113113
logger = getLogger(name)
114114
return logger, path

tests/searchcommands/data/app/default/logging.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ handlers = log_file ; Default: stderr
99
qualname = SearchCommand
1010
level = NOTSET ; Default: WARNING
1111
handlers = log_file ; Default: stderr
12+
propagate = 0 ; Default: 1
1213

1314
[handlers]
1415
keys=log_file, stderr

0 commit comments

Comments
 (0)