Fix: accessing /server/* endpoints doesn't 403 if namespace is set.

Ex: If namespace is set to `{'owner': 'admin', 'app': 'search'}`,
then we don't want to access /servicesNS/admin/search/server/info.
(This was the behavior before this change).

Author: Shakeel Mohamed

splunklib/binding.py

@@ -857,7 +857,7 @@ def _abspath(self, path_segment,
         # endpoint. Otherwise, use /servicesNS with the specified
         # namespace. If only one of app and owner is specified, use
         # '-' for the other.
-        if ns.app is None and ns.owner is None:
+        if ns.app is None and ns.owner is None or path_segment.startswith("server"):
             return UrlEncoded("/services/%s" % path_segment, skip_encode=skip_encode)
 
         oname = "nobody" if ns.owner is None else ns.owner

tests/test_service.py

@@ -45,6 +45,22 @@ def test_info(self):
         for key in keys: 
             self.assertTrue(key in info.keys())
 
+    def test_info_with_namespace(self):
+        # Make sure we're not accessing /servicesNS/admin/search/server/info
+        # instead of /services/server/info
+        # Backup the values, which are probably set to None
+        owner, app = self.service.namespace["owner"], self.service.namespace["app"]
+
+        self.service.namespace["owner"] = self.service.username
+        self.service.namespace["app"] = "search"
+        try:
+            self.service.info
+        except Exception as e:
+            self.fail("Couldn't get the server info, probably got a 403! %s" % e.message)
+
+        self.service.namespace["owner"] = owner
+        self.service.namespace["app"] = app
+
     def test_without_namespace(self):
         service = client.connect(**self.opts.kwargs)
         service.apps.list()