added access to finished flag within metadata

Author: ashah-splunk

splunklib/searchcommands/internals.py

@@ -438,6 +438,9 @@ class ObjectView:
     def __init__(self, dictionary):
         self.__dict__ = dictionary
 
+    def update(self, obj):
+        self.__dict__.update(obj.__dict__)
+
     def __repr__(self):
         return repr(self.__dict__)
 

splunklib/searchcommands/search_command.py

@@ -967,7 +967,9 @@ def _execute_v2(self, ifile, process):
 
             self._finished = getattr(metadata, 'finished', False)
             self._record_writer.is_flushed = False
-
+            # metadata.update(self._metadata)
+            # self._metadata = metadata
+            self._metadata.update(metadata)
             self._execute_chunk_v2(process, result)
 
             self._record_writer.write_chunk(finished=self._finished)

tests/test_utils.py

@@ -89,10 +89,7 @@ def checkFilePermissions(dir_path):
                 path = os.path.join(dir_path, file)
                 if os.path.isfile(path):
                     permission = oct(os.stat(path).st_mode)
-                    if sys.version_info >= (3, 0):
-                        self.assertEqual(permission, '0o100644')
-                    else :
-                        self.assertEqual(permission, '0100644')
+                    self.assertEqual(permission, '0o100644')
                 else:
                     checkFilePermissions(path)