Fixed Stanza.submit to take a dict, not a string.

Added a test for it (and removed an unnecessary restart in the test suite).
Updated CHANGELOG.

Author: Frederick Ross

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.0
 
+* Stanza.submit now takes a dictionary of key/value pairs specifying the stanza instead of a raw string.
 * Namespace handling has changed subtly. Code that depends on namespace handling in detail may break.
 * Added User.role_entities to return a list of the actual entity objects for the
   roles of a user. User.roles still returns a list of the role names.

splunklib/client.py

@@ -1680,11 +1680,11 @@ class Stanza(Entity):
     def submit(self, stanza):
         """Populates a stanza in a given configuration file. #FRED? Thought KV pairs would be what you provide, not a single name.
 
-        :param stanza: The name of the stanza.
-        :type stanza: ``string``
-        :return: The new  :class:`Stanza` object.
+        :param stanza: A dictionary of key/value pairs to set in this stanza.
+        :type stanza: ``dict``
+        :return: The :class:`Stanza` object this method is called on.
         """
-        self.service.request(self.path, method="POST", body=stanza)
+        self.service.post(self.path, **stanza)
         return self
 
     def __len__(self):

tests/test_conf.py

@@ -50,6 +50,7 @@ def setUp(self):
 
     def tearDown(self):
         self.service.apps.delete(self.app_name)
+        self.clear_restart_message()
 
     def test_confs(self):
         confs = self.app_service.confs
@@ -83,6 +84,14 @@ def test_confs(self):
         self.assertEqual(len(stanza), 1)
         self.assertTrue(key in stanza)
 
+        values = {testlib.tmpname(): testlib.tmpname(),
+                  testlib.tmpname(): testlib.tmpname()}
+        stanza.submit(values)
+        stanza.refresh()
+        for key, value in values.iteritems():
+            self.assertTrue(key in stanza)
+            self.assertEqual(value, stanza[key])
+
         count = len(conf)
         conf.delete(stanza_name)
         self.assertFalse(stanza_name in conf)