Skip to content

Commit ea74bcc

Browse files
author
Shakeel Mohamed
committed
Added internal Jira ticket numbers to TODOs
1 parent f8ca38a commit ea74bcc

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def run(self):
143143
sdk_dir = os.path.abspath('.')
144144

145145
def exclude(path):
146-
# TODO: Replace with filter function because exclude is deprecated
146+
# TODO: DVPL-5866 - Replace with filter function because exclude is deprecated
147147
basename = os.path.basename(path)
148148
for pattern in ['.DS_Store', '.idea', '*.log', '*.py[co]']:
149149
if fnmatch(basename, pattern):

splunklib/searchcommands/search_command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ def records(reader):
366366
yield record
367367
return
368368

369-
# TODO: Is it possible to support anything other than write_error? It does not seem so.
369+
# TODO: DVPL-5865 - Is it possible to support anything other than write_error? It does not seem so.
370370

371371
def write_debug(self, message, *args):
372372
self._write_message(u'DEBUG', message, *args)

tests/searchcommands/test_decorators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def test_builtin_options(self):
107107

108108
self.assertEqual(len(command.logger.handlers), 0)
109109

110-
# TODO: capture this output and verify it
110+
# TODO: DVPL-5867 - capture this output and verify it
111111
command.logger.warning(
112112
'Test that output is directed to stderr without formatting')
113113

tests/searchcommands/test_examples.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def test_option_show_configuration(self):
273273
os.path.join('log', 'test_option_show_configuration.log')))
274274
return
275275

276-
# TODO, use a generating command that doesn't do random sampling because
276+
# TODO: DVPL-5869 - use a generating command that doesn't do random sampling because
277277
# a seed is no guarantee that the same sample is produced on every platform
278278
# and all versions of python
279279

@@ -421,7 +421,7 @@ def test_helloworld_generating_command_as_unit(self):
421421
return
422422

423423
def test_generating_command_on_server(self):
424-
# TODO: this test never has inconsistent results due to random sampling
424+
# TODO: DVPL-5870 - this test has inconsistent results due to random sampling
425425
expected, actual = self._getOneshotResults(
426426
'| simulate csv=population.csv rate=200 interval=00:00:01 duration=00:00:02 seed=%s' % TestSearchCommandsApp._seed,
427427
'test_generating_command_on_server')
@@ -700,7 +700,7 @@ def _open_data_file(cls, relative_path, mode):
700700

701701
@classmethod
702702
def _start_process(cls, args, stdin, stdout, stderr):
703-
# TODO: make a shell script to run some of these seperately, check results there
703+
# TODO: DVPL-5871 - make a shell script to run some of these separately, check results there
704704
return Popen(args, stdin=stdin, stdout=stdout, stderr=stderr,
705705
cwd=cls.app_bin)
706706

tests/test_collection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_list_with_search(self):
115115
expected = [ent.name for ent in coll.list()]
116116
if len(expected) == 0:
117117
logging.debug("No entities in collection %s; skipping test.", coll_name)
118-
# TODO: This should use a real search instead of *. Otherwise the test passes trivially.
118+
# TODO: DVPL-5868 - This should use a real search instead of *. Otherwise the test passes trivially.
119119
found = [ent.name for ent in coll.list(search="*")]
120120
self.assertEqual(expected, found,
121121
msg='on %s (expected: %s, found: %s)' % \

0 commit comments

Comments
 (0)