Skip to content

Commit 897fabc

Browse files
committed
Review Feedback Vol. 1
1 parent ae24dce commit 897fabc

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ asciidoctorj = '3.0.0'
33
groovy2 = '2.5.23'
44
groovy3 = '3.0.25'
55
groovy4 = '4.0.29'
6-
groovy5 = '5.0.1'
6+
groovy5 = '5.0.2'
77
jacoco = '0.8.14'
88
junit = '5.14.0'
99
# The VersionRange used by OSGi to check compatibility with JUnit Platform.

spock-specs/src/test/groovy/org/spockframework/smoke/mock/GroovyMockAbstractGlobalClass.groovy

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -138,24 +138,15 @@ class GroovyMockAbstractGlobalClass extends Specification {
138138
}
139139

140140
static abstract class AbstractClassA {
141-
//TODO: verify whether it is necessity to qualify the field access here due to a change in Groovy 5
142-
// or whether it is a Spock bug that needs to be fixed
143-
// https://issues.apache.org/jira/browse/GROOVY-11781
144-
static String getStaticName() { GroovyMockAbstractGlobalClass.NAME }
145-
146-
//TODO: verify whether it is necessity to qualify the field access here due to a change in Groovy 5
147-
// or whether it is a Spock bug that needs to be fixed
148-
// https://issues.apache.org/jira/browse/GROOVY-11781
141+
static String getStaticName() { NAME }
142+
149143
@SuppressWarnings('GrMethodMayBeStatic')
150-
String getName() { GroovyMockAbstractGlobalClass.NAME }
144+
String getName() { NAME }
151145
}
152146

153147
static class SubClassA extends AbstractClassA {}
154148

155149
static abstract class ClassB {
156-
//TODO: verify whether it is necessity to qualify the field access here due to a change in Groovy 5
157-
// or whether it is a Spock bug that needs to be fixed
158-
// https://issues.apache.org/jira/browse/GROOVY-11781
159-
static String getStaticName() { GroovyMockAbstractGlobalClass.NAME }
150+
static String getStaticName() { NAME }
160151
}
161152
}

0 commit comments

Comments
 (0)