Skip to content

Commit 8b58bf0

Browse files
authored
fix: Remove explicit arg that enables litelinks' use of openssl (kserve#127)
This won't change current behaviour since the default is to use netty's openssl-based TLS implementation anyhow. But it will allow overriding to use the native jdk TLS impl when needed. Signed-off-by: Nick Hill <[email protected]>
1 parent fa9d16d commit 8b58bf0

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/main/scripts/start.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,6 @@ echo "SHUTDOWN_TIMEOUT_MS=$SHUTDOWN_TIMEOUT_MS"
367367

368368
LITELINKS_ARGS="-Dlitelinks.cancel_on_client_close=true -Dlitelinks.threadcontexts=log_mdc -Dlitelinks.shutdown_timeout_ms=${SHUTDOWN_TIMEOUT_MS} -Dlitelinks.produce_pooled_bytebufs=true"
369369

370-
# have litelinks use OpenSSL instead of JDK TLS implementation (faster)
371-
LL_OPENSSL_ARG="-Dlitelinks.ssl.use_jdk=false"
372-
373370
# These two args are needed to use netty's off-the-books direct buffer allocation
374371
NETTY_DIRECTBUF_ARGS="-Dio.netty.tryReflectionSetAccessible=true --add-opens=java.base/java.nio=ALL-UNNAMED"
375372
# this defaults to equal max heap, which can result in container OOMKilled
@@ -414,7 +411,6 @@ exec $JAVA_HOME/bin/java -cp "$LL_JAR:lib/*" -XX:+UnlockExperimentalVMOptions -X
414411
${JAVA_MAXDIRECT_ARG} ${NETTY_MAXDIRECT_ARG} ${NETTY_DISABLE_CHECK_ARGS} \
415412
${GRPC_USE_SHARED_ALLOC_ARG} \
416413
${SSL_PK_ARG} ${TRUSTSTORE_ARG} ${LITELINKS_ARGS} ${CUSTOM_JVM_ARGS} \
417-
$LL_OPENSSL_ARG \
418414
$PRIVATE_ENDPOINT_ARG \
419415
$LOG_CONFIG_ARG $LOG_PERF_ARGS \
420416
com.ibm.watson.litelinks.server.LitelinksService \

0 commit comments

Comments
 (0)