Skip to content

Commit c252e2a

Browse files
[9.1] [Discover] Fix adhoc_data_views test not updating hits count (elastic#231624) (elastic#231677)
# Backport This will backport the following commits from `main` to `9.1`: - [[Discover] Fix adhoc_data_views test not updating hits count (elastic#231624)](elastic#231624) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ania Kowalska","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-13T17:18:49Z","message":"[Discover] Fix adhoc_data_views test not updating hits count (elastic#231624)","sha":"fff5a8ddc7290b48e5b8ae0b42961e9c5d718252","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6","v8.18.6"],"title":"[Discover] Fix adhoc_data_views test not updating hits count","number":231624,"url":"https://github.com/elastic/kibana/pull/231624","mergeCommit":{"message":"[Discover] Fix adhoc_data_views test not updating hits count (elastic#231624)","sha":"fff5a8ddc7290b48e5b8ae0b42961e9c5d718252"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231624","number":231624,"mergeCommit":{"message":"[Discover] Fix adhoc_data_views test not updating hits count (elastic#231624)","sha":"fff5a8ddc7290b48e5b8ae0b42961e9c5d718252"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ania Kowalska <[email protected]>
1 parent d301537 commit c252e2a

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

src/platform/test/functional/apps/discover/group4/_adhoc_data_views.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,18 +105,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
105105
operation: 'is',
106106
value: 'nestedValue',
107107
});
108+
109+
await header.waitUntilLoadingHasFinished();
110+
await discover.waitUntilSearchingHasFinished();
111+
108112
expect(await filterBar.hasFilter('nestedField.child', 'nestedValue')).to.be(true);
109113
await retry.try(async function () {
110114
expect(await discover.getHitCount()).to.be('1');
111115
});
112116
await filterBar.removeFilter('nestedField.child');
113117

118+
await header.waitUntilLoadingHasFinished();
119+
await discover.waitUntilSearchingHasFinished();
120+
114121
await queryBar.setQuery('test');
115122
await queryBar.submitQuery();
123+
124+
await header.waitUntilLoadingHasFinished();
125+
await discover.waitUntilSearchingHasFinished();
126+
116127
await retry.try(async () => expect(await discover.getHitCount()).to.be('22'));
117128

118129
await queryBar.clearQuery();
119130
await queryBar.submitQuery();
131+
132+
await header.waitUntilLoadingHasFinished();
133+
await discover.waitUntilSearchingHasFinished();
120134
});
121135

122136
it('should not update data view id when saving search first time', async () => {

x-pack/platform/test/serverless/functional/test_suites/discover/group4/_adhoc_data_views.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
106106
operation: 'is',
107107
value: 'nestedValue',
108108
});
109+
110+
await PageObjects.header.waitUntilLoadingHasFinished();
111+
await PageObjects.discover.waitUntilSearchingHasFinished();
112+
109113
expect(await filterBar.hasFilter('nestedField.child', 'nestedValue')).to.be(true);
110114
await retry.try(async function () {
111115
expect(await PageObjects.discover.getHitCount()).to.be('1');
112116
});
113117
await filterBar.removeFilter('nestedField.child');
114118

119+
await PageObjects.header.waitUntilLoadingHasFinished();
120+
await PageObjects.discover.waitUntilSearchingHasFinished();
121+
115122
await queryBar.setQuery('test');
116123
await queryBar.submitQuery();
124+
125+
await PageObjects.header.waitUntilLoadingHasFinished();
126+
await PageObjects.discover.waitUntilSearchingHasFinished();
127+
117128
await retry.try(async () => expect(await PageObjects.discover.getHitCount()).to.be('22'));
118129

119130
await queryBar.clearQuery();
120131
await queryBar.submitQuery();
132+
133+
await PageObjects.header.waitUntilLoadingHasFinished();
134+
await PageObjects.discover.waitUntilSearchingHasFinished();
121135
});
122136

123137
it('should not update data view id when saving search first time', async () => {

0 commit comments

Comments
 (0)