Merge pull request #209 from mjburghard/add-EmptyDisposable

Add EmptyDisposable

Author: dflems

MobiusCore/Source/Disposables/EmptyDisposable.swift

@@ -0,0 +1,15 @@
+// Copyright Spotify AB.
+// SPDX-License-Identifier: Apache-2.0
+
+import Foundation
+
+/// The `EmptyDisposable` class implements a `Disposable` type for when you don't have anything to dispose of.
+public final class EmptyDisposable: MobiusCore.Disposable {
+
+    /// Create an `EmptyDisposable`
+    public init() {}
+
+    public func dispose() {
+        // No-op
+    }
+}

MobiusCore/Source/EffectHandlers/EffectRouterDSL.swift

@@ -31,7 +31,7 @@ public extension _PartialEffectRouter {
         return to { parameters, callback in
             fireAndForget(parameters)
             callback.end()
-            return AnonymousDisposable {}
+            return EmptyDisposable()
         }
     }
 
@@ -47,7 +47,7 @@ public extension _PartialEffectRouter {
                 callback.send(event)
             }
             callback.end()
-            return AnonymousDisposable {}
+            return EmptyDisposable()
         }
     }
 }

MobiusCore/Source/EventSources/CompositeEventSourceBuilder.swift

@@ -29,7 +29,7 @@ public struct CompositeEventSourceBuilder<Event> {
     public func build() -> AnyEventSource<Event> {
         switch eventSources.count {
         case 0:
-            return AnyEventSource { _ in AnonymousDisposable {} }
+            return AnyEventSource { _ in EmptyDisposable() }
         case 1:
             return eventSources[0]
         default:

MobiusCore/Test/EffectHandlers/EffectHandlerTests.swift

@@ -72,5 +72,5 @@ private func handleEffect(effect: Effect, callback: EffectCallback<Event>) -> Di
         callback.send(.eventForEffect1)
     }
     callback.end()
-    return AnonymousDisposable {}
+    return EmptyDisposable()
 }

MobiusCore/Test/EffectHandlers/EffectRouterDSLTests.swift

@@ -156,7 +156,7 @@ class EffectRouterDSLTests: QuickSpec {
                         expect(effect).to(equal(.effect1))
                         callback.send(.eventForEffect1)
                         callback.end()
-                        return AnonymousDisposable {}
+                        return EmptyDisposable()
                     }
                     .asConnectable
                     .connect { events.append($0) }

MobiusCore/Test/EffectHandlers/EffectRouterTests.swift

@@ -87,7 +87,7 @@ class EffectRouterTests: QuickSpec {
                         .to { _, callback in
                             callback.send(.eventForEffect2)
                             callback.end()
-                            return AnonymousDisposable {}
+                            return EmptyDisposable()
                         }
                     .asConnectable
 
@@ -108,7 +108,7 @@ class EffectRouterTests: QuickSpec {
 
             beforeEach {
                 let handler = AnyEffectHandler<Effect, Event> { _, _ in
-                    AnonymousDisposable {}
+                    EmptyDisposable()
                 }
                 let invalidRouter = EffectRouter<Effect, Event>()
                     .routeEffects(equalTo: .multipleHandlersForThisEffect).to(handler)
@@ -152,7 +152,7 @@ class EffectRouterTests: QuickSpec {
                     .routeEffects(equalTo: .effect2)
                         .to { _, callback in
                             callback.end()
-                            return AnonymousDisposable {}
+                            return EmptyDisposable()
                         }
                     .asConnectable
 

MobiusCore/Test/NonReentrancyTests.swift

@@ -56,7 +56,7 @@ class NonReentrancyTests: QuickSpec {
 
                 let testEffectHandler = AnyEffectHandler<Effect, Event> {
                     handleEffect($0, $1)
-                    return AnonymousDisposable {}
+                    return EmptyDisposable()
                 }
 
                 let effectConnectable = EffectRouter<Effect, Event>()

MobiusExtras/Test/EventSource+ExtensionsTests.swift

@@ -16,7 +16,7 @@ class EventSourceExtensionsTests: QuickSpec {
             beforeEach {
                 intEventSource = AnyEventSource { (consumer: @escaping (Int) -> Void) in
                     subscribedIntConsumer = consumer
-                    return AnonymousDisposable {}
+                    return EmptyDisposable()
                 }
             }