Merge pull request #239 from danaospo/remove-retry-on-404

Fix: Do Not Retry on 404 HTTP Status Code

Author: gitrema

Sources/SPTDataLoader/SPTDataLoaderResponse.m

@@ -106,8 +106,8 @@ - (BOOL)shouldRetry
             case SPTDataLoaderResponseHTTPStatusCodeExpectationFail:
             case SPTDataLoaderResponseHTTPStatusCodeHTTPVersionNotSupported:
             case SPTDataLoaderResponseHTTPStatusCodeNotImplemented:
-                return NO;
             case SPTDataLoaderResponseHTTPStatusCodeNotFound:
+                return NO;
             case SPTDataLoaderResponseHTTPStatusCodeRequestTimeout:
             case SPTDataLoaderResponseHTTPStatusCodeUnsupportedMediaTypes:
             case SPTDataLoaderResponseHTTPStatusCodeInternalServerError:

Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m

@@ -125,7 +125,7 @@ - (void)testRetry
     [self.handler receiveResponse:httpResponse];
     [self.handler completeWithError:nil];
     XCTAssertEqual(self.requestResponseHandler.numberOfSuccessfulDataResponseCalls, 0u, @"The handler did relay a successful response onto its request response handler when it should have silently retried");
-    XCTAssertEqual(self.requestResponseHandler.numberOfFailedResponseCalls, 0u, @"The handler did relay a failed response onto its request response handler when it should have silently retried");
+    XCTAssertEqual(self.requestResponseHandler.numberOfFailedResponseCalls, 1u, @"The handler did not relay a failed response onto its request response handler for a 404 status code");
 }
 
 - (void)testRetryWithResponseBody

Tests/SPTDataLoader/SPTDataLoaderResponseTest.m

@@ -69,7 +69,7 @@ - (void)testShouldRetryWithNotFoundHTTPStatusCode
                                                  headerFields:nil];
     self.response = [SPTDataLoaderResponse dataLoaderResponseWithRequest:self.request response:self.urlResponse];
     BOOL shouldRetry = [self.response shouldRetry];
-    XCTAssertTrue(shouldRetry, @"The response should retry when given the HTTP status code of Not Found");
+    XCTAssertFalse(shouldRetry, @"The response should not retry when given the HTTP status code of Not Found");
 }
 
 - (void)testShouldRetryForCertificateRejection