Break out activity setup logic

Author: antonholmberg

auth-lib/src/testAuth/java/com/spotify/sdk/android/auth/LoginActivityAuthTest.java

@@ -45,9 +45,17 @@
 @RunWith(RobolectricTestRunner.class)
 public class LoginActivityAuthTest {
 
-    @Test
-    public void shouldFinishLoginActivityWhenCompleted() {
+    private static class LoginActivitySetup {
+        final LoginActivity loginActivity;
+        final ShadowActivity shadowLoginActivity;
+
+        LoginActivitySetup(LoginActivity loginActivity, ShadowActivity shadowLoginActivity) {
+            this.loginActivity = loginActivity;
+            this.shadowLoginActivity = shadowLoginActivity;
+        }
+    }
 
+    private LoginActivitySetup createLoginActivity() {
         Activity context = Robolectric
                 .buildActivity(Activity.class)
                 .create()
@@ -57,106 +65,65 @@ public void shouldFinishLoginActivityWhenCompleted() {
         AuthorizationRequest request = new AuthorizationRequest.Builder("test", AuthorizationResponse.Type.TOKEN, "test://test")
                 .setPkceInformation(pkceInfo)
                 .build();
-        AuthorizationResponse response = new AuthorizationResponse.Builder()
-                .setType(AuthorizationResponse.Type.TOKEN)
-                .setAccessToken("test_token")
-                .setExpiresIn(3600)
-                .build();
 
         Bundle bundle = new Bundle();
         bundle.putParcelable(LoginActivity.REQUEST_KEY, request);
 
         Intent intent = new Intent(context, LoginActivity.class);
         intent.putExtra(LoginActivity.EXTRA_AUTH_REQUEST, bundle);
 
-        ActivityController<LoginActivity> loginActivityActivityController = buildActivity(LoginActivity.class, intent);
-
-        final LoginActivity loginActivity = loginActivityActivityController.get();
-
-        final ShadowActivity shadowLoginActivity = shadowOf(loginActivity);
+        ActivityController<LoginActivity> loginActivityController = buildActivity(LoginActivity.class, intent);
+        LoginActivity loginActivity = loginActivityController.get();
+        ShadowActivity shadowLoginActivity = shadowOf(loginActivity);
         shadowLoginActivity.setCallingActivity(context.getComponentName());
+        loginActivityController.create();
 
-        loginActivityActivityController.create();
-
-        assertFalse(loginActivity.isFinishing());
+        return new LoginActivitySetup(loginActivity, shadowLoginActivity);
+    }
 
-        loginActivity.onClientComplete(response);
+    private void assertCompletion(LoginActivitySetup setup, AuthorizationResponse response, int expectedResultCode) {
+        setup.loginActivity.onClientComplete(response);
 
-        assertTrue(loginActivity.isFinishing());
-        assertEquals(Activity.RESULT_OK, shadowLoginActivity.getResultCode());
-        assertEquals(response, shadowLoginActivity.getResultIntent().getBundleExtra(LoginActivity.EXTRA_AUTH_RESPONSE).get(LoginActivity.RESPONSE_KEY));
+        assertTrue(setup.loginActivity.isFinishing());
+        assertEquals(expectedResultCode, setup.shadowLoginActivity.getResultCode());
+        assertEquals(response, setup.shadowLoginActivity.getResultIntent().getBundleExtra(LoginActivity.EXTRA_AUTH_RESPONSE).get(LoginActivity.RESPONSE_KEY));
     }
 
     @Test
-    public void shouldReturnResultCanceledWhenUserCancels() {
-        Activity context = Robolectric
-                .buildActivity(Activity.class)
-                .create()
-                .get();
-
-        PKCEInformation pkceInfo = PKCEInformation.sha256("test_verifier", "test_challenge");
-        AuthorizationRequest request = new AuthorizationRequest.Builder("test", AuthorizationResponse.Type.TOKEN, "test://test")
-                .setPkceInformation(pkceInfo)
-                .build();
+    public void shouldFinishLoginActivityWhenCompleted() {
+        LoginActivitySetup setup = createLoginActivity();
 
-        // Create CANCELLED response type (user cancellation)
         AuthorizationResponse response = new AuthorizationResponse.Builder()
-                .setType(AuthorizationResponse.Type.CANCELLED)
+                .setType(AuthorizationResponse.Type.TOKEN)
+                .setAccessToken("test_token")
+                .setExpiresIn(3600)
                 .build();
 
-        Bundle bundle = new Bundle();
-        bundle.putParcelable(LoginActivity.REQUEST_KEY, request);
+        assertFalse(setup.loginActivity.isFinishing());
 
-        Intent intent = new Intent(context, LoginActivity.class);
-        intent.putExtra(LoginActivity.EXTRA_AUTH_REQUEST, bundle);
+        assertCompletion(setup, response, Activity.RESULT_OK);
+    }
 
-        ActivityController<LoginActivity> loginActivityActivityController = buildActivity(LoginActivity.class, intent);
-        final LoginActivity loginActivity = loginActivityActivityController.get();
-        final ShadowActivity shadowLoginActivity = shadowOf(loginActivity);
-        shadowLoginActivity.setCallingActivity(context.getComponentName());
-        loginActivityActivityController.create();
+    @Test
+    public void shouldReturnResultCanceledWhenUserCancels() {
+        LoginActivitySetup setup = createLoginActivity();
 
-        loginActivity.onClientComplete(response);
+        AuthorizationResponse response = new AuthorizationResponse.Builder()
+                .setType(AuthorizationResponse.Type.CANCELLED)
+                .build();
 
-        assertTrue(loginActivity.isFinishing());
-        assertEquals(Activity.RESULT_CANCELED, shadowLoginActivity.getResultCode());
-        assertEquals(response, shadowLoginActivity.getResultIntent().getBundleExtra(LoginActivity.EXTRA_AUTH_RESPONSE).get(LoginActivity.RESPONSE_KEY));
+        assertCompletion(setup, response, Activity.RESULT_CANCELED);
     }
 
     @Test
     public void shouldReturnResultOkForTechnicalErrors() {
-        Activity context = Robolectric
-                .buildActivity(Activity.class)
-                .create()
-                .get();
+        LoginActivitySetup setup = createLoginActivity();
 
-        PKCEInformation pkceInfo = PKCEInformation.sha256("test_verifier", "test_challenge");
-        AuthorizationRequest request = new AuthorizationRequest.Builder("test", AuthorizationResponse.Type.TOKEN, "test://test")
-                .setPkceInformation(pkceInfo)
-                .build();
-
-        // Create EMPTY response (technical error)
         AuthorizationResponse response = new AuthorizationResponse.Builder()
                 .setType(AuthorizationResponse.Type.EMPTY)
                 .build();
 
-        Bundle bundle = new Bundle();
-        bundle.putParcelable(LoginActivity.REQUEST_KEY, request);
-
-        Intent intent = new Intent(context, LoginActivity.class);
-        intent.putExtra(LoginActivity.EXTRA_AUTH_REQUEST, bundle);
-
-        ActivityController<LoginActivity> loginActivityActivityController = buildActivity(LoginActivity.class, intent);
-        final LoginActivity loginActivity = loginActivityActivityController.get();
-        final ShadowActivity shadowLoginActivity = shadowOf(loginActivity);
-        shadowLoginActivity.setCallingActivity(context.getComponentName());
-        loginActivityActivityController.create();
-
-        loginActivity.onClientComplete(response);
-
-        assertTrue(loginActivity.isFinishing());
-        assertEquals(Activity.RESULT_OK, shadowLoginActivity.getResultCode());  // Technical errors return OK
-        assertEquals(response, shadowLoginActivity.getResultIntent().getBundleExtra(LoginActivity.EXTRA_AUTH_RESPONSE).get(LoginActivity.RESPONSE_KEY));
+        assertCompletion(setup, response, Activity.RESULT_OK);
     }
 
 }