Skip to content

Commit ad83963

Browse files
authored
Comment out dead code in models.py (#180)
1 parent fe5e6e8 commit ad83963

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

basic_pitch/models.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -223,17 +223,20 @@ def model(
223223
N_FREQ_BINS_CONTOURS,
224224
)(x)
225225

226-
# contour layers - fully convolutional
227-
x_contours = tfkl.Conv2D(
228-
n_filters_contour,
229-
CONTOUR_KERNEL_SIZE_1,
230-
padding="same",
231-
kernel_initializer=_initializer(),
232-
kernel_constraint=_kernel_constraint(),
233-
)(x)
234-
235-
x_contours = tfkl.BatchNormalization()(x_contours)
236-
x_contours = tfkl.ReLU()(x_contours)
226+
# contour layers - fully convolutional - /!\ commented out as it was unintentionally skipped
227+
# when training the model presented in the paper.
228+
# TODO: retrain with layer included and replace checkpoints if it yields benefits
229+
#
230+
# x_contours = tfkl.Conv2D(
231+
# n_filters_contour,
232+
# CONTOUR_KERNEL_SIZE_1,
233+
# padding="same",
234+
# kernel_initializer=_initializer(),
235+
# kernel_constraint=_kernel_constraint(),
236+
# )(x)
237+
238+
# x_contours = tfkl.BatchNormalization()(x_contours)
239+
# x_contours = tfkl.ReLU()(x_contours)
237240

238241
x_contours = tfkl.Conv2D(
239242
CONTOUR_FILTERS_2,

0 commit comments

Comments
 (0)