refactor: More cleanups

Author: fabriziodemaria

openfeature-provider-local/src/main/java/com/spotify/confidence/Account.java

@@ -19,7 +19,6 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Timer;
-import java.util.TimerTask;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.LongAdder;
@@ -29,7 +28,6 @@
 class AssignLogger implements Closeable {
   private static final Logger logger = LoggerFactory.getLogger(AssignLogger.class);
 
-  private static final Logger LOG = LoggerFactory.getLogger(AssignLogger.class);
   // Max size minus some wiggle room
   private static final int GRPC_MESSAGE_MAX_SIZE = 4194304 - 1048576;
 
@@ -63,31 +61,6 @@ private Long timeSinceLastAssigned() {
     return Duration.between(lastFlagAssigned, Instant.now()).toMillis();
   }
 
-  static AssignLogger createStarted(
-      InternalFlagLoggerServiceGrpc.InternalFlagLoggerServiceBlockingStub flagLoggerStub,
-      Duration checkpointInterval,
-      MetricRegistry metricRegistry,
-      long capacity) {
-    final Timer timer = new Timer("assign-logger-timer", true);
-    final AssignLogger assignLogger =
-        new AssignLogger(flagLoggerStub, timer, metricRegistry, capacity);
-
-    timer.scheduleAtFixedRate(
-        new TimerTask() {
-          @Override
-          public void run() {
-            try {
-              assignLogger.checkpoint();
-            } catch (Exception e) {
-              LOG.error("Failed to checkpoint assignments", e);
-            }
-          }
-        },
-        checkpointInterval.toMillis(),
-        checkpointInterval.toMillis());
-    return assignLogger;
-  }
-
   @VisibleForTesting
   Collection<FlagAssigned> queuedAssigns() {
     return ImmutableList.copyOf(queue);

openfeature-provider-local/src/main/java/com/spotify/confidence/AssignLogger.java

@@ -32,24 +32,6 @@ class DefaultDeadlineClientInterceptor implements ClientInterceptor {
     this.duration = duration;
   }
 
-  /**
-   * Get the current default deadline duration.
-   *
-   * @return the current default deadline duration
-   */
-  Duration getDuration() {
-    return duration;
-  }
-
-  /**
-   * Set a new default deadline duration.
-   *
-   * @param duration the new default deadline duration
-   */
-  void setDuration(Duration duration) {
-    this.duration = duration;
-  }
-
   @Override
   public <ReqT, RespT> ClientCall<ReqT, RespT> interceptCall(
       MethodDescriptor<ReqT, RespT> method, CallOptions callOptions, Channel next) {

openfeature-provider-local/src/main/java/com/spotify/confidence/BadRequestException.java

@@ -1,52 +1,15 @@
 package com.spotify.confidence;
 
-import static com.spotify.confidence.ResolvedValue.resolveToAssignmentReason;
-
-import com.google.protobuf.Struct;
 import com.google.protobuf.Timestamp;
+import com.spotify.confidence.shaded.flags.resolver.v1.ResolveReason;
 import com.spotify.confidence.shaded.flags.resolver.v1.Sdk;
 import com.spotify.confidence.shaded.flags.resolver.v1.events.ClientInfo;
-import com.spotify.confidence.shaded.flags.resolver.v1.events.FallthroughAssignment;
 import com.spotify.confidence.shaded.flags.resolver.v1.events.FlagAssigned;
-import java.util.ArrayList;
+import com.spotify.confidence.shaded.flags.resolver.v1.events.FlagAssigned.DefaultAssignment.DefaultAssignmentReason;
 import java.util.List;
 
 interface FlagLogger {
 
-  void logResolve(
-      String resolveId,
-      Struct evaluationContext,
-      Sdk sdk,
-      AccountClient accountClient,
-      List<ResolvedValue> values);
-
-  void logAssigns(
-      String resolveId, Sdk sdk, List<FlagToApply> flagsToApply, AccountClient accountClient);
-
-  static List<String> getResources(FlagAssigned flagAssigned) {
-    final List<String> resources = new ArrayList<>();
-    for (var flag : flagAssigned.getFlagsList()) {
-      if (flag.hasAssignmentInfo()) {
-        if (!flag.getAssignmentInfo().getSegment().isBlank()) {
-          resources.add(flag.getAssignmentInfo().getSegment());
-        }
-        if (!flag.getAssignmentInfo().getVariant().isBlank()) {
-          resources.add(flag.getAssignmentInfo().getVariant());
-        }
-      }
-
-      for (FallthroughAssignment fallthroughAssignment : flag.getFallthroughAssignmentsList()) {
-        resources.add(fallthroughAssignment.getRule());
-      }
-
-      resources.add(flag.getFlag());
-      resources.add(flag.getRule());
-    }
-    resources.add(flagAssigned.getClientInfo().getClient());
-    resources.add(flagAssigned.getClientInfo().getClientCredential());
-    return resources;
-  }
-
   static FlagAssigned createFlagAssigned(
       String resolveId, Sdk sdk, List<FlagToApply> flagsToApply, AccountClient accountClient) {
     final var clientInfo =
@@ -90,4 +53,13 @@ static FlagAssigned createFlagAssigned(
 
     return builder.build();
   }
+
+  private static DefaultAssignmentReason resolveToAssignmentReason(ResolveReason reason) {
+    return switch (reason) {
+      case RESOLVE_REASON_NO_SEGMENT_MATCH -> DefaultAssignmentReason.NO_SEGMENT_MATCH;
+      case RESOLVE_REASON_NO_TREATMENT_MATCH -> DefaultAssignmentReason.NO_TREATMENT_MATCH;
+      case RESOLVE_REASON_FLAG_ARCHIVED -> DefaultAssignmentReason.FLAG_ARCHIVED;
+      default -> DefaultAssignmentReason.DEFAULT_ASSIGNMENT_REASON_UNSPECIFIED;
+    };
+  }
 }

openfeature-provider-local/src/main/java/com/spotify/confidence/DefaultDeadlineClientInterceptor.java

@@ -21,8 +21,4 @@ synchronized void setStatus(HealthCheckResponse.ServingStatus status) {
     this.status.set(status);
     healthStatusManager.setStatus(SERVICE_NAME_ALL_SERVICES, status);
   }
-
-  HealthCheckResponse.ServingStatus get() {
-    return status.get();
-  }
 }

openfeature-provider-local/src/main/java/com/spotify/confidence/EvalUtil.java

@@ -9,11 +9,7 @@
 import java.util.Optional;
 
 class JwtUtils {
-  public static final String AUTH0_ISSUER = "https://auth.confidence.dev/";
-  public static final String[] AUTH0_ISSUERS =
-      new String[] {"https://konfidens.eu.auth0.com/", AUTH0_ISSUER};
 
-  public static final String BEARER_TYPE = "Bearer";
   public static final Metadata.Key<String> AUTHORIZATION_METADATA_KEY =
       Metadata.Key.of("Authorization", ASCII_STRING_MARSHALLER);
 
@@ -38,10 +34,6 @@ public static Optional<Claim> getClaim(final DecodedJWT jwt, final String claim)
     }
   }
 
-  public static boolean isValidToken(String token) {
-    return token.startsWith(BEARER_TYPE);
-  }
-
   public static String getTokenAsHeader(String rawToken) {
     return String.format("Bearer %s", rawToken);
   }