fix: add test for ResolveHint logging

Author: nicklasl

sdk-java/pom.xml

@@ -10,12 +10,6 @@
   <artifactId>sdk-java</artifactId>
 
   <dependencies>
-    <dependency>
-      <groupId>com.google.protobuf</groupId>
-      <artifactId>protobuf-java-util</artifactId>
-      <version>${protobuf.version}</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>io.grpc</groupId>
       <artifactId>grpc-protobuf</artifactId>
@@ -42,6 +36,12 @@
       <artifactId>proto-google-common-protos</artifactId>
       <version>${common.protos.version}</version>
     </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+      <version>1.4.14</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>

sdk-java/src/main/java/com/spotify/confidence/Confidence.java

@@ -201,7 +201,6 @@ public void logResolveTesterHint(ResolvedFlag resolvedFlag) {
     final String clientKey = client().clientSecret;
     final String flag = resolvedFlag.getFlag();
     try {
-
       final ResolveTesterLogging resolveTesterLogging =
           ResolveTesterLogging.newBuilder()
               .setClientKey(clientKey)

sdk-java/src/test/java/com/spotify/confidence/ConfidenceTest.java

@@ -2,6 +2,10 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
+import ch.qos.logback.classic.Level;
+import ch.qos.logback.classic.Logger;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import ch.qos.logback.core.read.ListAppender;
 import com.google.protobuf.Value;
 import com.spotify.confidence.ConfidenceValue.Struct;
 import com.spotify.confidence.shaded.flags.resolver.v1.ResolveFlagsResponse;
@@ -15,18 +19,33 @@
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.CompletableFuture;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.slf4j.LoggerFactory;
 
 final class ConfidenceTest {
   private final FakeEventSenderEngine fakeEngine = new FakeEventSenderEngine(new FakeClock());
   private final ResolverClientTestUtils.FakeFlagResolverClient fakeFlagResolverClient =
       new ResolverClientTestUtils.FakeFlagResolverClient();
   private static Confidence confidence;
+  private ListAppender<ILoggingEvent> listAppender;
+  private Logger confidenceLogger;
 
   @BeforeEach
   void beforeEach() {
     confidence = Confidence.create(fakeEngine, fakeFlagResolverClient, "clientKey");
+    confidenceLogger = (Logger) LoggerFactory.getLogger(Confidence.class);
+
+    listAppender = new ListAppender<>();
+    listAppender.start();
+    // Add the appender to the logger
+    confidenceLogger.addAppender(listAppender);
+  }
+
+  @AfterEach
+  void afterEach() {
+    confidenceLogger.detachAppender(listAppender);
   }
 
   @Test
@@ -259,6 +278,22 @@ void internalError() {
         evaluation.getErrorMessage().get().startsWith("Crashing while performing network call"));
   }
 
+  @Test
+  void shouldLogResolverHint() {
+    confidence
+        .withContext(Map.of("my_context_value", ConfidenceValue.of(42)))
+        .logResolveTesterHint(ResolvedFlag.newBuilder().setFlag("FlagName").build());
+    final List<ILoggingEvent> loggingEvents = listAppender.list;
+    assertTrue(loggingEvents.size() > 0, "No log message was captured.");
+    final ILoggingEvent lastLogEvent = loggingEvents.get(loggingEvents.size() - 1);
+    assertEquals(Level.DEBUG, lastLogEvent.getLevel()); // Or whatever level you expect
+    assertEquals(
+        "Check your flag evaluation for 'FlagName' by copy pasting the payload to the Resolve tester "
+            + "'ewogICJjbGllbnRLZXkiOiAiY2xpZW50S2V5IiwKICAiZmxhZyI6ICJGbGFnTmFtZSIsCiAgImN"
+            + "vbnRleHQiOiB7CiAgICAibXlfY29udGV4dF92YWx1ZSI6IDQyLjAKICB9Cn0='",
+        lastLogEvent.getFormattedMessage());
+  }
+
   public static class FailingFlagResolverClient implements FlagResolverClient {
 
     @Override