fix tests for SearchTest

Author: sindunuragarp

src/test/java/com/spotify/github/v3/clients/SearchClientTest.java

@@ -63,6 +63,6 @@ public void testSearchIssue() throws Exception {
     when(github.request(ISSUES_URI + "?q=bogus-q", SearchIssues.class)).thenReturn(fixture);
     final SearchIssues search =
         searchClient.issues(ImmutableSearchParameters.builder().q("bogus-q").build()).get();
-    assertSearchIssues(search, 35802);
+    assertSearchIssues(search);
   }
 }

src/test/java/com/spotify/github/v3/search/SearchTest.java

@@ -34,15 +34,15 @@
 
 public class SearchTest {
 
-  public static final void assertSearchIssues(final SearchIssues search, long id) {
+  public static final void assertSearchIssues(final SearchIssues search) {
     final Issue issues = search.items().get(0);
     assertThat(search.totalCount(), is(280));
     assertThat(search.incompleteResults(), is(false));
     assertThat(
         issues.url(),
         is(URI.create("https://api.github.com/repos/batterseapower/pinyin-toolkit/issues/132")));
     assertThat(issues.number(), is(132));
-    assertThat(issues.id(), is(id));
+    assertThat(issues.id(), is(35802L));
     assertThat(issues.title(), is("Line Number Indexes Beyond 20 Not Displayed"));
   }
 
@@ -52,15 +52,19 @@ public void testDeserialization() throws IOException {
         Resources.toString(getResource(this.getClass(), "issues.json"), defaultCharset());
 
     final SearchIssues search = Json.create().fromJson(fixture, SearchIssues.class);
-    assertSearchIssues(search, 35802);
+    assertSearchIssues(search);
   }
 
   @Test
   public void testDeserializationWithLargeIssueId() throws IOException {
     final String fixture =
-        Resources.toString(getResource(this.getClass(), "issues-with-large-id.json"), defaultCharset());
+        Resources.toString(getResource(this.getClass(), "issues-long-id.json"), defaultCharset());
 
     final SearchIssues search = Json.create().fromJson(fixture, SearchIssues.class);
-    assertSearchIssues(search, 2147534768L);
+    assertThat(search.items().size(), is(1));
+
+    final Issue issue = search.items().get(0);
+    assertThat(issue.id(), is(2592843837L));
+    assertThat(issue.number(), is(5514));
   }
 }

src/test/resources/com/spotify/github/v3/search/issues-long-id.json

@@ -0,0 +1,72 @@
+{
+  "total_count": 280,
+  "incomplete_results": false,
+  "items": [
+    {
+      "url": "https://api.github.com/repos/spotify/scio/issues/5514",
+      "repository_url": "https://api.github.com/repos/spotify/scio",
+      "labels_url": "https://api.github.com/repos/spotify/scio/issues/5514/labels{/name}",
+      "comments_url": "https://api.github.com/repos/spotify/scio/issues/5514/comments",
+      "events_url": "https://api.github.com/repos/spotify/scio/issues/5514/events",
+      "html_url": "https://github.com/spotify/scio/issues/5514",
+      "id": 2592843837,
+      "node_id": "I_kwDOAfa55s6ai6g9",
+      "number": 5514,
+      "title": "Benchmark BigTable maxPendingRequests",
+      "user": {
+        "login": "kellen",
+        "id": 486691,
+        "node_id": "MDQ6VXNlcjQ4NjY5MQ==",
+        "avatar_url": "https://avatars.githubusercontent.com/u/486691?v=4",
+        "gravatar_id": "",
+        "url": "https://api.github.com/users/kellen",
+        "html_url": "https://github.com/kellen",
+        "followers_url": "https://api.github.com/users/kellen/followers",
+        "following_url": "https://api.github.com/users/kellen/following{/other_user}",
+        "gists_url": "https://api.github.com/users/kellen/gists{/gist_id}",
+        "starred_url": "https://api.github.com/users/kellen/starred{/owner}{/repo}",
+        "subscriptions_url": "https://api.github.com/users/kellen/subscriptions",
+        "organizations_url": "https://api.github.com/users/kellen/orgs",
+        "repos_url": "https://api.github.com/users/kellen/repos",
+        "events_url": "https://api.github.com/users/kellen/events{/privacy}",
+        "received_events_url": "https://api.github.com/users/kellen/received_events",
+        "type": "User",
+        "user_view_type": "public",
+        "site_admin": false
+      },
+      "labels": [
+
+      ],
+      "state": "open",
+      "locked": false,
+      "assignee": null,
+      "assignees": [
+
+      ],
+      "milestone": null,
+      "comments": 0,
+      "created_at": "2024-10-16T19:23:04Z",
+      "updated_at": "2024-10-16T19:23:40Z",
+      "closed_at": null,
+      "author_association": "CONTRIBUTOR",
+      "active_lock_reason": null,
+      "body": "Internal spotify discussions suggest that the default `maxPendingRequests=1` may no longer be a good default and a higher value (e.g. `6`) may make more sense for batch. \r\n\r\nWe should write some benchmarks to verify and update the documentation and/or defaults based on the benchmark results.\r\n",
+      "closed_by": null,
+      "reactions": {
+        "url": "https://api.github.com/repos/spotify/scio/issues/5514/reactions",
+        "total_count": 0,
+        "+1": 0,
+        "-1": 0,
+        "laugh": 0,
+        "hooray": 0,
+        "confused": 0,
+        "heart": 0,
+        "rocket": 0,
+        "eyes": 0
+      },
+      "timeline_url": "https://api.github.com/repos/spotify/scio/issues/5514/timeline",
+      "performed_via_github_app": null,
+      "state_reason": null
+    }
+  ]
+}