Skip to content

Commit 65fadd7

Browse files
Abhi347Abhi347
committed
test: Moar tests
1 parent aab703e commit 65fadd7

File tree

2 files changed

+151
-73
lines changed

2 files changed

+151
-73
lines changed

‎src/test/java/com/spotify/github/tracing/OpenCensusSpanTest.java‎

Lines changed: 128 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* Licensed under the Apache License, Version 2.0 (the "License");
88
* you may not use this file except in compliance with the License.
99
* You may obtain a copy of the License at
10-
*
10+
*
1111
* http://www.apache.org/licenses/LICENSE-2.0
12-
*
12+
*
1313
* Unless required by applicable law or agreed to in writing, software
1414
* distributed under the License is distributed on an "AS IS" BASIS,
1515
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -31,75 +31,130 @@
3131
import static org.mockito.Mockito.verify;
3232

3333
class OpenCensusSpanTest {
34-
private final io.opencensus.trace.Span wrapped = mock(io.opencensus.trace.Span.class);
35-
36-
@Test
37-
public void succeed() {
38-
final Span span = new OpenCensusSpan(wrapped);
39-
span.success();
40-
span.close();
41-
42-
verify(wrapped).setStatus(Status.OK);
43-
verify(wrapped).end();
44-
}
45-
46-
@Test
47-
public void fail() {
48-
final Span span = new OpenCensusSpan(wrapped);
49-
span.failure(new RequestNotOkException("method", "path", 404, "Not found", Collections.emptyMap()));
50-
span.close();
51-
52-
verify(wrapped).setStatus(Status.UNKNOWN);
53-
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(404));
54-
verify(wrapped).end();
55-
}
56-
57-
@Test
58-
public void failOnServerError() {
59-
final Span span = new OpenCensusSpan(wrapped);
60-
span.failure(new RequestNotOkException("method", "path", 500, "Internal Server Error", Collections.emptyMap()));
61-
span.close();
62-
63-
verify(wrapped).setStatus(Status.UNKNOWN);
64-
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(500));
65-
verify(wrapped).putAttribute("error", AttributeValue.booleanAttributeValue(true));
66-
verify(wrapped).end();
67-
}
68-
69-
@Test
70-
@SuppressWarnings("deprecation")
71-
public void succeedDeprecated() {
72-
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
73-
span.success();
74-
span.close();
75-
76-
verify(wrapped).setStatus(Status.OK);
77-
verify(wrapped).end();
78-
}
79-
80-
@Test
81-
@SuppressWarnings("deprecation")
82-
public void failDeprecated() {
83-
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
84-
span.failure(new RequestNotOkException("method", "path", 404, "Not found", Collections.emptyMap()));
85-
span.close();
86-
87-
verify(wrapped).setStatus(Status.UNKNOWN);
88-
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(404));
89-
verify(wrapped).end();
90-
}
91-
92-
@Test
93-
@SuppressWarnings("deprecation")
94-
public void failOnServerErrorDeprecated() {
95-
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
96-
span.failure(new RequestNotOkException("method", "path", 500, "Internal Server Error", Collections.emptyMap()));
97-
span.close();
98-
99-
verify(wrapped).setStatus(Status.UNKNOWN);
100-
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(500));
101-
verify(wrapped).putAttribute("error", AttributeValue.booleanAttributeValue(true));
102-
verify(wrapped).end();
103-
}
104-
34+
private final io.opencensus.trace.Span wrapped = mock(io.opencensus.trace.Span.class);
35+
36+
@Test
37+
public void succeed() {
38+
final Span span = new OpenCensusSpan(wrapped);
39+
span.success();
40+
span.close();
41+
42+
verify(wrapped).setStatus(Status.OK);
43+
verify(wrapped).end();
44+
}
45+
46+
@Test
47+
public void fail() {
48+
final Span span = new OpenCensusSpan(wrapped);
49+
span.failure(
50+
new RequestNotOkException("method", "path", 404, "Not found", Collections.emptyMap()));
51+
span.close();
52+
53+
verify(wrapped).setStatus(Status.UNKNOWN);
54+
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(404));
55+
verify(wrapped).end();
56+
}
57+
58+
@Test
59+
public void failOnServerError() {
60+
final Span span = new OpenCensusSpan(wrapped);
61+
span.failure(
62+
new RequestNotOkException(
63+
"method", "path", 500, "Internal Server Error", Collections.emptyMap()));
64+
span.close();
65+
66+
verify(wrapped).setStatus(Status.UNKNOWN);
67+
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(500));
68+
verify(wrapped).putAttribute("error", AttributeValue.booleanAttributeValue(true));
69+
verify(wrapped).end();
70+
}
71+
72+
@Test
73+
public void addTags() {
74+
final Span span = new OpenCensusSpan(wrapped);
75+
span.addTag("key", "value");
76+
span.addTag("key", true);
77+
span.addTag("key", 42L);
78+
span.close();
79+
80+
verify(wrapped).putAttribute("key", AttributeValue.stringAttributeValue("value"));
81+
verify(wrapped).putAttribute("key", AttributeValue.booleanAttributeValue(true));
82+
verify(wrapped).putAttribute("key", AttributeValue.longAttributeValue(42L));
83+
verify(wrapped).end();
84+
}
85+
86+
@Test
87+
public void addEvent() {
88+
final Span span = new OpenCensusSpan(wrapped);
89+
span.addEvent("description");
90+
span.close();
91+
92+
verify(wrapped).addAnnotation("description");
93+
verify(wrapped).end();
94+
}
95+
96+
@Test
97+
@SuppressWarnings("deprecation")
98+
public void succeedDeprecated() {
99+
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
100+
span.success();
101+
span.close();
102+
103+
verify(wrapped).setStatus(Status.OK);
104+
verify(wrapped).end();
105+
}
106+
107+
@Test
108+
@SuppressWarnings("deprecation")
109+
public void failDeprecated() {
110+
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
111+
span.failure(
112+
new RequestNotOkException("method", "path", 404, "Not found", Collections.emptyMap()));
113+
span.close();
114+
115+
verify(wrapped).setStatus(Status.UNKNOWN);
116+
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(404));
117+
verify(wrapped).end();
118+
}
119+
120+
@Test
121+
@SuppressWarnings("deprecation")
122+
public void failOnServerErrorDeprecated() {
123+
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
124+
span.failure(
125+
new RequestNotOkException(
126+
"method", "path", 500, "Internal Server Error", Collections.emptyMap()));
127+
span.close();
128+
129+
verify(wrapped).setStatus(Status.UNKNOWN);
130+
verify(wrapped).putAttribute("http.status_code", AttributeValue.longAttributeValue(500));
131+
verify(wrapped).putAttribute("error", AttributeValue.booleanAttributeValue(true));
132+
verify(wrapped).end();
133+
}
134+
135+
@Test
136+
@SuppressWarnings("deprecation")
137+
public void addTagsDeprecated() {
138+
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
139+
span.addTag("key", "value");
140+
span.addTag("key", true);
141+
span.addTag("key", 42L);
142+
span.close();
143+
144+
verify(wrapped).putAttribute("key", AttributeValue.stringAttributeValue("value"));
145+
verify(wrapped).putAttribute("key", AttributeValue.booleanAttributeValue(true));
146+
verify(wrapped).putAttribute("key", AttributeValue.longAttributeValue(42L));
147+
verify(wrapped).end();
148+
}
149+
150+
@Test
151+
@SuppressWarnings("deprecation")
152+
public void addEventDeprecated() {
153+
final Span span = new com.spotify.github.opencensus.OpenCensusSpan(wrapped);
154+
span.addEvent("description");
155+
span.close();
156+
157+
verify(wrapped).addAnnotation("description");
158+
verify(wrapped).end();
159+
}
105160
}

‎src/test/java/com/spotify/github/tracing/OpenTelemetrySpanTest.java‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,27 @@ public void failWithNonRequestNotOkException() {
9191
verify(wrapped).setAttribute("error", true);
9292
verify(wrapped).end();
9393
}
94+
95+
@Test
96+
public void addTags() {
97+
final Span span = new OpenTelemetrySpan(wrapped);
98+
span.addTag("key", "value");
99+
span.addTag("key", true);
100+
span.addTag("key", 42L);
101+
span.close();
102+
103+
verify(wrapped).setAttribute("key", "value");
104+
verify(wrapped).setAttribute("key", true);
105+
verify(wrapped).setAttribute("key", 42L);
106+
}
107+
108+
@Test
109+
public void addEvent() {
110+
final Span span = new OpenTelemetrySpan(wrapped);
111+
span.addEvent("description");
112+
span.close();
113+
114+
verify(wrapped).addEvent("description");
115+
verify(wrapped).end();
116+
}
94117
}

0 commit comments

Comments
 (0)