Skip to content

Commit d5f995f

Browse files
authored
Merge branch 'master' into feat/add-ot-support
2 parents f08d604 + eeff7bf commit d5f995f

File tree

14 files changed

+16
-14
lines changed

14 files changed

+16
-14
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44

55
<artifactId>github-client</artifactId>
6-
<version>0.3.3-SNAPSHOT</version>
6+
<version>0.3.4-SNAPSHOT</version>
77

88
<parent>
99
<groupId>com.spotify</groupId>
@@ -67,7 +67,7 @@
6767
<properties>
6868
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
6969
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
70-
<project.build.outputTimestamp>1726146382</project.build.outputTimestamp>
70+
<project.build.outputTimestamp>1737127111</project.build.outputTimestamp>
7171
<spotbugs.excludeFilterFile>spotbugsexclude.xml</spotbugs.excludeFilterFile>
7272
<checkstyle.violationSeverity>error</checkstyle.violationSeverity>
7373
<checkstyle.config.location>checkstyle.xml</checkstyle.config.location>

src/main/java/com/spotify/github/jackson/Json.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
package com.spotify.github.jackson;
2222

23-
import static com.fasterxml.jackson.databind.PropertyNamingStrategy.SNAKE_CASE;
23+
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
2424
import static java.util.Objects.isNull;
2525

2626
import com.fasterxml.jackson.annotation.JsonInclude;
@@ -248,6 +248,6 @@ private static class DefaultMapper {
248248
.enable(SerializationFeature.WRITE_DATES_WITH_ZONE_ID)
249249
.enable(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES)
250250
.setSerializationInclusion(JsonInclude.Include.NON_NULL)
251-
.setPropertyNamingStrategy(SNAKE_CASE);
251+
.setPropertyNamingStrategy(PropertyNamingStrategies.SNAKE_CASE);
252252
}
253253
}

src/main/java/com/spotify/github/v3/activity/events/CreateEvent.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public interface CreateEvent extends BaseEvent {
4747
String masterBranch();
4848

4949
/** The repository's current description. */
50-
@Nullable
5150
Optional<String> description();
5251

5352
/** No doc found on github - Usually is "user". */

src/main/java/com/spotify/github/v3/activity/events/PushEvent.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ public interface PushEvent {
9393
List<PushCommit> commits();
9494

9595
/** The push commit object of the most recent commit on ref after the push. */
96-
@Nullable
9796
Optional<PushCommit> headCommit();
9897

9998
/** Pusher */

src/main/java/com/spotify/github/v3/activity/events/StatusEvent.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public interface StatusEvent extends BaseEvent, UpdateTracking {
6666
String context();
6767

6868
/** The optional human-readable description added to the status. */
69-
@Nullable
7069
Optional<String> description();
7170

7271
/** The new state. Can be pending, success, failure, or error. */

src/main/java/com/spotify/github/v3/comment/Comment.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public interface Comment extends UpdateTracking {
6060
*
6161
* @deprecated Use {@link #position()} instead
6262
*/
63+
@Deprecated
6364
Optional<Integer> line();
6465

6566
/** Relative path of the file to comment on. */

src/main/java/com/spotify/github/v3/exceptions/GithubException.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
/** Common github exception */
2424
public class GithubException extends RuntimeException {
25+
private static final long serialVersionUID = 1L;
26+
2527

2628
/**
2729
* C'tor for setting a message

src/main/java/com/spotify/github/v3/exceptions/ReadOnlyRepositoryException.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525

2626
/** The Read only repository exception. */
2727
public class ReadOnlyRepositoryException extends RequestNotOkException {
28+
private static final long serialVersionUID = 1L;
29+
2830
/**
2931
* Instantiates a new Read only repository exception.
3032
*

src/main/java/com/spotify/github/v3/exceptions/RequestNotOkException.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939

4040
/** HTTP response with non-200 StatusCode. */
4141
public class RequestNotOkException extends GithubException {
42+
private static final long serialVersionUID = 1L;
43+
4244

4345
private final int statusCode;
4446
private final String method;

src/main/java/com/spotify/github/v3/issues/Issue.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,9 @@ public interface Issue extends CloseTracking {
4848
URI url();
4949

5050
/** Events URL. */
51-
@Nullable
5251
Optional<URI> eventsUrl();
5352

5453
/** Repository URL. */
55-
@Nullable
5654
Optional<URI> repositoryUrl();
5755

5856
/** Labels URL template. */
@@ -80,7 +78,6 @@ public interface Issue extends CloseTracking {
8078
String title();
8179

8280
/** The contents of the issue. */
83-
@Nullable
8481
Optional<String> body();
8582

8683
/** User. */

0 commit comments

Comments
 (0)