Skip to content
This repository was archived by the owner on Jan 21, 2025. It is now read-only.

Commit 71c0ab3

Browse files
author
Caesar Ralf
committed
Remove guava dependency
1 parent 05ce168 commit 71c0ab3

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,6 @@
125125
<artifactId>jackson-databind</artifactId>
126126
<scope>test</scope>
127127
</dependency>
128-
<dependency>
129-
<groupId>com.google.guava</groupId>
130-
<artifactId>guava</artifactId>
131-
<version>17.0</version>
132-
<scope>test</scope>
133-
</dependency>
134128
</dependencies>
135129

136130
<build>

src/test/java/com/spotify/logging/LoggingConfiguratorTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import ch.qos.logback.classic.net.SyslogAppender;
5050
import ch.qos.logback.core.ConsoleAppender;
5151
import ch.qos.logback.core.status.Status;
52-
import com.google.common.collect.FluentIterable;
5352
import com.spotify.logging.logback.CustomLogstashEncoder;
5453
import io.sentry.logback.SentryAppender;
5554
import net.logstash.logback.composite.loggingevent.ArgumentsJsonProvider;
@@ -214,9 +213,9 @@ private void assertLogstashEncoder(final Level level) {
214213
final CustomLogstashEncoder encoder = (CustomLogstashEncoder) stdout.getEncoder();
215214
assertEquals(
216215
1,
217-
FluentIterable.from(encoder.getProviders().getProviders())
218-
.filter(ArgumentsJsonProvider.class)
219-
.size());
216+
encoder.getProviders().getProviders().stream()
217+
.filter(ArgumentsJsonProvider.class::isInstance)
218+
.count());
220219
}
221220

222221
private void assertDefault(final String ident, final Level level) {

src/test/java/com/spotify/logging/logback/LogstashEncoderTest.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@
2626
import com.fasterxml.jackson.core.JsonProcessingException;
2727
import com.fasterxml.jackson.databind.JsonNode;
2828
import com.fasterxml.jackson.databind.ObjectMapper;
29-
import com.google.common.collect.ImmutableList;
30-
import com.google.common.collect.ImmutableMap;
3129
import com.spotify.logging.LoggingConfigurator;
3230
import com.spotify.logging.LoggingConfigurator.Level;
31+
import java.util.Arrays;
32+
import java.util.HashMap;
33+
import java.util.Map;
3334
import net.logstash.logback.encoder.LogstashEncoder;
3435
import org.junit.Rule;
3536
import org.junit.Test;
@@ -52,8 +53,8 @@ public void shouldIncludeStructuredArguments() throws JsonProcessingException {
5253
"foo={} bar={} list={} map={} thing={}",
5354
value("foo", 17),
5455
value("bar", "quux"),
55-
value("list", ImmutableList.of(1, 2)),
56-
value("map", ImmutableMap.of("a", 3, "b", 4)),
56+
value("list", Arrays.asList(1, 2)),
57+
value("map", mapOf("a", 3, "b", 4)),
5758
value("thing", new Thing(5, "6")));
5859
final String log = systemOutRule.getLog();
5960
final JsonNode parsedMessage = mapper.readTree(log);
@@ -67,6 +68,14 @@ public void shouldIncludeStructuredArguments() throws JsonProcessingException {
6768
assertEquals(mapper.createObjectNode().put("v1", 5).put("v2", "6"), parsedMessage.get("thing"));
6869
}
6970

71+
private <V> Map<String, V> mapOf(
72+
final String keyA, final V valueA, final String keyB, final V valueB) {
73+
final Map<String, V> map = new HashMap<>();
74+
map.put(keyA, valueA);
75+
map.put(keyB, valueB);
76+
return map;
77+
}
78+
7079
public static class Thing {
7180

7281
private final int v1;

0 commit comments

Comments
 (0)