Commit da392e6
authored
remove StreamingBodyAdaptor that didn't allow choosing the chunk size (#2929)
This StreamingBodyAdaptor caused performance issues:
Calling `__iter__()` on a StreamingBodyAdaptor object defaulted to chunks of 1 byte, which was really slowing
down reads. I wasn't able to pass the `size` parameter to change the chunk size
botocore StreamingBody implementation performs better:
https://github.com/boto/botocore/blob/master/botocore/response.py#L90
It defaults to chunks of 1024 bytes, and can be adjusted.
It also offers iter_lines() and iter_chunks() methods1 parent 3c2712b commit da392e6
1 file changed
+1
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 78 | | |
95 | 79 | | |
96 | 80 | | |
| |||
586 | 570 | | |
587 | 571 | | |
588 | 572 | | |
589 | | - | |
| 573 | + | |
590 | 574 | | |
591 | 575 | | |
592 | 576 | | |
| |||
0 commit comments