Skip to content

Commit a60ba28

Browse files
5peak2menathan3d
authored andcommitted
Remove inspection warnings and fix doc error
1 parent 3cd353c commit a60ba28

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ ruler {
7676

7777
### Running the task
7878

79-
Once this is done, `analyze<VariantName>Bundle` tasks will be added for each of your app variants. Running this task will build the app and generate a HTML report, which you can use to analyze your app size. It will also generate a JSON report, in case you want to further process the data.
79+
Once this is done, `analyze<VariantName>Bundle` tasks will be added for each of your app variants. Running this task will build the app and generate an HTML report, which you can use to analyze your app size. It will also generate a JSON report, in case you want to further process the data.
8080

8181
## Ownership
8282

@@ -133,7 +133,7 @@ The project is set up like a standard Gradle project. You can build it using `./
133133

134134
There is also a sample project, which shows the usage of the plugin. Because the way this sample project is set up, the initial build can fail if you bump the plugin version. To fix this, you have to publish the plugin to your local Maven repository by running `./gradlew publishToMavenLocal -PwithoutSample`.
135135

136-
When working on the frontend, you can start a development server by running `./gradlew browserRun`, which will show a report filled with dummy data to make development easier.
136+
When working on the frontend, you can start a development server by running `./gradlew jsBrowserRun`, which will show a report filled with dummy data to make development easier.
137137

138138
## Compatibility
139139

ruler-frontend/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ plugins {
2222
kotlin {
2323
js(IR) {
2424
browser {
25-
commonWebpackConfig (Action {
25+
commonWebpackConfig(Action {
2626
cssSupport {
2727
enabled.set(true)
2828
}

ruler-gradle-plugin/src/main/kotlin/com/spotify/ruler/plugin/FileProvider.kt

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
/*
2+
* Copyright 2021 Spotify AB
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
116
package com.spotify.ruler.plugin
217

318
import com.android.build.api.artifact.SingleArtifact
@@ -63,7 +78,7 @@ internal fun Project.getResourceMappingFile(
6378
variant: ApplicationVariant
6479
): Provider<RegularFile> {
6580
val defaultResourceMappingFile = project.objects.fileProperty() // Empty by default
66-
@Suppress("SpellCheckingInspection")
81+
6782
val resourceMappingFilePath = when {
6883
hasDexGuard(project) -> "outputs/dexguard/mapping/bundle/${variant.name}/resourcefilenamemapping.txt"
6984
else -> return defaultResourceMappingFile // No DexGuard plugin -> use default empty file
@@ -88,6 +103,5 @@ private fun hasDexGuard(project: Project): Boolean {
88103

89104
/** Checks if the given [project] is using ProGuard for obfuscation, instead of R8. */
90105
private fun hasProGuard(project: Project): Boolean {
91-
@Suppress("SpellCheckingInspection")
92106
return project.pluginManager.hasPlugin("com.guardsquare.proguard")
93107
}

sample/lib/src/main/res/layout/activity_lib.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
android:layout_height="match_parent"
2222
android:paddingVertical="18dp"
2323
android:paddingHorizontal="12dp"
24-
tools:context=".MainActivity">
24+
tools:context=".LibActivity">
2525

2626
<TextView
2727
android:layout_width="wrap_content"

0 commit comments

Comments
 (0)