Remove now-unnecessary chmod call

Author: rockbruno

Sources/SourceKitBazelBSP/RequestHandlers/PrepareHandler.swift

@@ -95,9 +95,6 @@ final class PrepareHandler {
             cmd: "build \(labelsToBuild.joined(separator: " "))"
         )
 
-        // FIXME: This might not be necessary anymore
-        // _ = try commandRunner.run("chmod -R 777 \(initializedConfig.outputBase)")
-
         logger.info("Finished building targets!")
     }
 }

Sources/SourceKitBazelBSP/Server/SourceKitBazelBSPServer.swift

@@ -95,20 +95,7 @@ package final class SourceKitBazelBSPServer {
             targetStore: targetStore,
             connection: connection
         )
-        registry.register(requestHandler: { (request: TextDocumentSourceKitOptionsRequest, id: RequestID) in
-            // Handle the optional response type properly - if nil is returned for valid reasons
-            // (like missing module entries), return an empty response instead of nil to prevent connection closure
-            if let response = try skOptionsHandler.textDocumentSourceKitOptions(request, id) {
-                return response
-            } else {
-                // Return an empty response with no compiler arguments rather than nil
-                // This prevents SourceKit LSP from closing the connection
-                return TextDocumentSourceKitOptionsResponse(
-                    compilerArguments: [],
-                    workingDirectory: initializedConfig.rootUri
-                )
-            }
-        })
+        registry.register(requestHandler: skOptionsHandler.textDocumentSourceKitOptions)
 
         // buildTarget/prepare
         let prepareHandler = PrepareHandler(

Tests/SourceKitBazelBSPTests/PrepareHandlerTests.swift

@@ -54,12 +54,6 @@ import Testing
             for: expectedCommand,
             response: "")
 
-        let chmodCommand = "chmod -R 777 /tmp/output_base"
-        commandRunner.setResponse(
-            for: chmodCommand,
-            response: ""
-        )
-
         let handler = PrepareHandler(
             initializedConfig: initializedConfig,
             targetStore: BazelTargetStore(initializedConfig: initializedConfig),
@@ -70,11 +64,9 @@ import Testing
         try handler.build(bazelLabels: baseConfig.targets)
 
         let ranCommands = commandRunner.commands
-        #expect(ranCommands.count == 2)
+        #expect(ranCommands.count == 1)
         #expect(ranCommands[0].command == expectedCommand)
         #expect(ranCommands[0].cwd == "/path/to/project")
-        #expect(ranCommands[1].command == chmodCommand)
-        #expect(ranCommands[1].cwd == nil)
     }
 
     func buildWithMultipleTargets() throws {
@@ -104,12 +96,6 @@ import Testing
             for: expectedCommand,
             response: "Build completed")
 
-        let chmodCommand = "chmod -R 777 /tmp/output_base"
-        commandRunner.setResponse(
-            for: chmodCommand,
-            response: "Done"
-        )
-
         let handler = PrepareHandler(
             initializedConfig: initializedConfig,
             targetStore: BazelTargetStore(initializedConfig: initializedConfig),
@@ -120,10 +106,8 @@ import Testing
         try handler.build(bazelLabels: baseConfig.targets)
 
         let ranCommands = commandRunner.commands
-        #expect(ranCommands.count == 2)
+        #expect(ranCommands.count == 1)
         #expect(ranCommands[0].command == expectedCommand)
         #expect(ranCommands[0].cwd == "/path/to/project")
-        #expect(ranCommands[1].command == chmodCommand)
-        #expect(ranCommands[1].cwd == nil)
     }
 }