small fixes

Author: Alex Danilenko

core/src/main/java/spotty/common/http/ContentEncoding.java

@@ -15,9 +15,13 @@
  */
 package spotty.common.http;
 
+import spotty.common.exception.SpottyException;
+
 import java.util.HashMap;
 import java.util.Map;
 
+import static java.util.Arrays.asList;
+
 public enum ContentEncoding {
     GZIP, DEFLATE;
 
@@ -31,6 +35,11 @@ public enum ContentEncoding {
     }
 
     public static ContentEncoding of(String name) {
-        return MAPPING.get(name);
+        final ContentEncoding contentEncoding = MAPPING.get(name);
+        if (contentEncoding == null) {
+            throw new SpottyException("Spotty supports " + asList(ContentEncoding.values()) + " compression");
+        }
+
+        return contentEncoding;
     }
 }

core/src/main/java/spotty/server/handler/request/DefaultRequestHandler.java

@@ -15,7 +15,6 @@
  */
 package spotty.server.handler.request;
 
-import spotty.common.exception.SpottyException;
 import spotty.common.filter.Filter;
 import spotty.common.http.ContentEncoding;
 import spotty.common.request.SpottyDefaultRequest;
@@ -28,7 +27,6 @@
 
 import java.util.Collection;
 
-import static java.util.Arrays.asList;
 import static spotty.common.http.HttpHeaders.ACCEPT;
 import static spotty.common.http.HttpHeaders.CONTENT_ENCODING;
 import static spotty.common.validation.Validation.notNull;
@@ -79,9 +77,6 @@ public void handle(SpottyDefaultRequest request, SpottyResponse response) throws
 
         if (response.headers().has(CONTENT_ENCODING)) {
             final ContentEncoding contentEncoding = ContentEncoding.of(response.headers().get(CONTENT_ENCODING));
-            if (contentEncoding == null) {
-                throw new SpottyException("Spotty supports " + asList(ContentEncoding.values()) + " compression");
-            }
 
             body = compressor.compress(contentEncoding, body);
         }

core/src/main/java/spotty/server/worker/ReactorWorker.java

@@ -69,7 +69,7 @@ ThreadPoolExecutor reactorPool() {
      */
     private static class RejectedHandler implements RejectedExecutionHandler {
 
-        private final ExecutorService rejectedHandlerExecutor = newSingleThreadExecutor();
+        private final ExecutorService rejectedHandlerExecutor = newSingleThreadExecutor(threadPool("spotty-reactor-rejected-handler"));
 
         @Override
         public void rejectedExecution(Runnable task, ThreadPoolExecutor executor) {

core/src/test/groovy/spotty/server/connection/ConnectionTest.groovy

@@ -10,6 +10,7 @@ import spotty.common.response.SpottyResponse
 import spotty.common.stream.output.SpottyByteArrayOutputStream
 import spotty.server.connection.socket.SocketFactory
 import spotty.server.handler.EchoRequestHandler
+import spotty.server.handler.request.RequestHandler
 import spotty.server.registry.exception.ExceptionHandlerRegistry
 import spotty.server.worker.ReactorWorker
 import stub.SocketChannelStub
@@ -61,13 +62,14 @@ class ConnectionTest extends Specification implements WebRequestTestData {
 
     def "should read request correctly"() {
         given:
+        final RequestHandler delayHandler = (req, res) -> Thread.sleep(1000)
         var expectedRequest = aSpottyRequest()
         var socket = new SocketChannelStub(fullRequest.length())
         socket.configureBlocking(false)
         socket.write(fullRequest)
         socket.flip()
 
-        var connection = new Connection(socketFactory.createSocket(socket), new EchoRequestHandler(), reactorWorker, exceptionService, maxBodyLimit)
+        var connection = new Connection(socketFactory.createSocket(socket), delayHandler, reactorWorker, exceptionService, maxBodyLimit)
         connection.markReadyToRead()
 
         when: