-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
In sveltejs/svelte#6750, there is a proposed change to the StartStopNotifier type of Svelte stores, which will be a breaking change for anyone creating custom stores. See the PR for details, but the short version is that if that PR is accepted and merged into Svelte, you'll need to make some small changes to your custom store to maintain Svelte compatibility, as follows:
- Inside your
writablefunction, changestop = start(set) || noop;tostop = start(set, update) || noop;in thesubscribe()implementation. - Inside your
derivedfunction, changereturn readable(initial_value, (set) => {toreturn readable(initial_value, (set, update) => {and then changeconst result = fn(single ? values[0] : values, set);toconst result = fn(single ? values[0] : values, set, update);
In your repo, the affected code appears to be in store.js.
If you have any comments about the proposed breaking change, please come leave a comment on the Svelte PR to let me know whether it would make your life easier or harder.
Metadata
Metadata
Assignees
Labels
No labels