Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 698b336

Browse files
committed
Close writer
- Make sure PrintWriter is closed after yaml dump - While fixing obvious file handle leak makes junit's temp dir deletion to work - Fixes #187
1 parent 7dcc32b commit 698b336

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/org/springframework/cli/roles/RoleService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ public void updateRole(String roleName, String key, Object value) {
8484
dumperOptions.setLineBreak(DumperOptions.LineBreak.getPlatformLineBreak());
8585
Yaml yaml = new Yaml(dumperOptions);
8686
File getRoleFile = getFile(roleName);
87-
try {
88-
yaml.dump(map, new PrintWriter(getRoleFile));
87+
try (PrintWriter writer = new PrintWriter(getRoleFile)) {
88+
yaml.dump(map, writer);
8989
}
9090
catch (FileNotFoundException ex) {
9191
throw new SpringCliException(

0 commit comments

Comments
 (0)