Added AnnotationUseStyle to checkstyle config

updated code so that validation passes
resolves #1408

Updated copyright

Author: cppwfs

spring-cloud-dataflow-rest-client/src/main/java/org/springframework/cloud/dataflow/rest/client/support/StepExecutionHistoryJacksonMixIn.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016 the original author or authors.
+ * Copyright 2016-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,7 +31,7 @@
 @JsonIgnoreProperties({ "count", "durationPerRead" })
 public abstract class StepExecutionHistoryJacksonMixIn {
 
-	@JsonCreator()
+	@JsonCreator
 	StepExecutionHistoryJacksonMixIn(@JsonProperty("stepName") String stepName) {
 	}
 

spring-cloud-dataflow-rest-client/src/main/java/org/springframework/cloud/dataflow/rest/client/support/StepExecutionJacksonMixIn.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016 the original author or authors.
+ * Copyright 2016-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,7 +31,7 @@
 @JsonIgnoreProperties({ "jobParameters", "jobExecutionId", "skipCount", "summary" })
 public abstract class StepExecutionJacksonMixIn {
 
-	@JsonCreator()
+	@JsonCreator
 	StepExecutionJacksonMixIn(@JsonProperty("stepName") String stepName) {
 	}
 

spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/CompletionController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2015-2016 the original author or authors.
+ * Copyright 2015-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -72,7 +72,7 @@ public CompletionController(StreamCompletionProvider completionProvider,
 	 * 1. Higher values request more detail, with values typically in the range [1..5]
 	 * @return the list of completion proposals
 	 */
-	@RequestMapping(value = "/stream")
+	@RequestMapping("/stream")
 	public CompletionProposalsResource completions(@RequestParam("start") String start,
 			@RequestParam(value = "detailLevel", defaultValue = "1") @Min(value = 1, message = "The provided detail level must be greater than zero.") int detailLevel) {
 		return assembler.toResource(completionProvider.complete(start, detailLevel));
@@ -87,7 +87,7 @@ public CompletionProposalsResource completions(@RequestParam("start") String sta
 	 * 1. Higher values request more detail, with values typically in the range [1..5]
 	 * @return the list of completion proposals
 	 */
-	@RequestMapping(value = "/task")
+	@RequestMapping("/task")
 	public CompletionProposalsResource taskCompletions(@RequestParam("start") String start,
 			@RequestParam(value = "detailLevel", defaultValue = "1") @Min(value = 1, message = "The provided detail level must be greater than zero.") int detailLevel) {
 		return assembler.toResource(taskCompletionProvider.complete(start, detailLevel));

spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/metrics/FakeMetricsCollector.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017 the original author or authors.
+ * Copyright 2017-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -68,7 +68,7 @@ public class FakeMetricsCollector {
 
 	private static final Log LOGGER = LogFactory.getLog(FakeMetricsCollector.class);
 
-	@Value(value = "classpath:/org/springframework/cloud/dataflow/server/local/metrics/metrics-collector-sample-response.json")
+	@Value("classpath:/org/springframework/cloud/dataflow/server/local/metrics/metrics-collector-sample-response.json")
 	private Resource metricsCollectorResponseResource;
 
 	public static void main(String[] args) {

spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityWithSingleUserTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2017 the original author or authors.
+ * Copyright 2016-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -68,19 +68,19 @@ public class LocalServerSecurityWithSingleUserTests {
 
 	private static UserCredentials singleUser = new UserCredentials("user", "password");
 
-	@Parameter(value = 0)
+	@Parameter(0)
 	public HttpMethod httpMethod;
 
-	@Parameter(value = 1)
+	@Parameter(1)
 	public HttpStatus expectedHttpStatus;
 
-	@Parameter(value = 2)
+	@Parameter(2)
 	public String url;
 
-	@Parameter(value = 3)
+	@Parameter(3)
 	public UserCredentials userCredentials;
 
-	@Parameter(value = 4)
+	@Parameter(4)
 	public Map<String, String> urlParameters;
 
 	@Parameters(name = "Authentication Test {index} - {0} {2} - Returns: {1}")

spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityWithUsersFileTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2017 the original author or authors.
+ * Copyright 2016-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -71,19 +71,19 @@ public class LocalServerSecurityWithUsersFileTests {
 
 	private static UserCredentials createOnlyUser = new UserCredentials("cartman", "cartmanpwd");
 
-	@Parameter(value = 0)
+	@Parameter(0)
 	public HttpMethod httpMethod;
 
-	@Parameter(value = 1)
+	@Parameter(1)
 	public HttpStatus expectedHttpStatus;
 
-	@Parameter(value = 2)
+	@Parameter(2)
 	public String url;
 
-	@Parameter(value = 3)
+	@Parameter(3)
 	public UserCredentials userCredentials;
 
-	@Parameter(value = 4)
+	@Parameter(4)
 	public Map<String, String> urlParameters;
 
 	@Parameters(name = "Authentication Test {index} - {0} {2} - Returns: {1}")

spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityWithUsersFileTestsWithoutTasks.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017 the original author or authors.
+ * Copyright 2017-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -73,19 +73,19 @@ public class LocalServerSecurityWithUsersFileTestsWithoutTasks {
 
 	private static UserCredentials createOnlyUser = new UserCredentials("cartman", "cartmanpwd");
 
-	@Parameter(value = 0)
+	@Parameter(0)
 	public HttpMethod httpMethod;
 
-	@Parameter(value = 1)
+	@Parameter(1)
 	public HttpStatus expectedHttpStatus;
 
-	@Parameter(value = 2)
+	@Parameter(2)
 	public String url;
 
-	@Parameter(value = 3)
+	@Parameter(3)
 	public UserCredentials userCredentials;
 
-	@Parameter(value = 4)
+	@Parameter(4)
 	public Map<String, String> urlParameters;
 
 	@Parameters(name = "Authentication Test {index} - {0} {2} - Returns: {1}")

src/checkstyle/checkstyle.xml

@@ -18,9 +18,11 @@
         <!--</module>-->
 
         <!-- Annotations -->
-        <!--<module name="AnnotationUseStyle">-->
-        <!--<property name="elementStyle" value="compact"/>-->
-        <!--</module>-->
+        <module name="AnnotationUseStyle">
+            <property name="elementStyle" value="compact"/>
+            <property name="trailingArrayComma" value="never"/>
+            <property name="closingParens" value="never"/>
+        </module>
         <module name="MissingOverride"/>
         <module name="PackageAnnotation"/>
         <module name="AnnotationLocation">