Fix About controller version info to check correct snapshot

Resolves #4445

Author: ilayaperumalg

spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AboutController.java

@@ -304,7 +304,7 @@ private String repoSelector(String version) {
 		final String MAVEN_ROOT = "https://repo1.maven.org/maven2";
 
 		String result = MAVEN_ROOT;
-		if (version.endsWith("BUILD-SNAPSHOT")) {
+		if (version.endsWith("-SNAPSHOT")) {
 			result = REPO_SNAPSHOT_ROOT;
 		}
 		else if (version.contains(".M")) {

spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/AboutControllerTests.java

@@ -144,6 +144,43 @@ public void testChecksumDisabled() throws Exception {
 		}
 	}
 
+	@RunWith(SpringRunner.class)
+	@SpringBootTest(classes = TestDependencies.class)
+	@DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_EACH_TEST_METHOD)
+	@TestPropertySource(properties = {
+			"spring.cloud.dataflow.version-info.dependencies.spring-cloud-dataflow-shell.version=2.7.2-SNAPSHOT",
+			"spring.cloud.dataflow.version-info.dependency-fetch.enabled=false",
+			"spring.cloud.dataflow.version-info.dependencies.spring-cloud-dataflow-shell.checksum-sha1=ABCDEFG"
+	})
+	@AutoConfigureTestDatabase(replace = Replace.ANY)
+	public static class SnapshotUrlTests {
+
+		private MockMvc mockMvc;
+
+		@Rule
+		public LogTestNameRule logTestName = new LogTestNameRule();
+
+		@Autowired
+		private WebApplicationContext wac;
+
+		@Before
+		public void setupMocks() {
+			this.mockMvc = MockMvcBuilders.webAppContextSetup(wac)
+					.defaultRequest(get("/").accept(MediaType.APPLICATION_JSON)).build();
+		}
+
+		@Test
+		public void testSnapshotVersionInfo() throws Exception {
+			ResultActions result = mockMvc.perform(get("/about").accept(MediaType.APPLICATION_JSON)).andDo(print()).andExpect(status().isOk());
+			result.andExpect(jsonPath("$.featureInfo.analyticsEnabled", is(true)))
+					.andExpect(jsonPath("$.versionInfo.shell.name", is("Spring Cloud Data Flow Shell")))
+					.andExpect(jsonPath("$.versionInfo.shell.url", is("https://repo.spring.io/libs-snapshot/org/springframework/cloud/spring-cloud-dataflow-shell/2.7.2-SNAPSHOT/spring-cloud-dataflow-shell-2.7.2-SNAPSHOT.jar")))
+					.andExpect(jsonPath("$.versionInfo.shell.version", is("2.7.2-SNAPSHOT")))
+					.andExpect(jsonPath("$.versionInfo.shell.checksumSha1").doesNotExist())
+					.andExpect(jsonPath("$.versionInfo.shell.checksumSha256").doesNotExist());
+		}
+	}
+
 	@RunWith(SpringRunner.class)
 	@SpringBootTest(classes = TestDependencies.class)
 	@DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_EACH_TEST_METHOD)