Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 7298eb5

Browse files
committed
Another attempt to handle the bamboo. env. varaiable prefixes for ITs
1 parent 25fcf29 commit 7298eb5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spring-cloud-dataflow-server/src/test/java/org/springframework/cloud/dataflow/integration/test/util/DockerComposeFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ public class DockerComposeFactory {
106106
DockerComposeFactoryProperties.get(DockerComposeFactoryProperties.TEST_DOCKER_COMPOSE_TASK_APPS_URI, (isDood ? "https://dataflow.spring.io/task-docker-latest" : DEFAULT_TASK_APPS_URI)))
107107
.withAdditionalEnvironmentVariable("DOCKER_DELETE_CONTAINER_ON_EXIT",
108108
"" + DockerComposeFactoryProperties.getBoolean(DockerComposeFactoryProperties.TEST_DOCKER_COMPOSE_DOCKER_DELETE_CONTAINER_ON_EXIT, true))
109-
.withAdditionalEnvironmentVariable("bamboo.SCDF_ITS_DOCKERHUB_USER", DockerComposeFactoryProperties.get("bamboo.SCDF_ITS_DOCKERHUB_USER", ""))
110-
.withAdditionalEnvironmentVariable("bamboo.SCDF_ITS_DOCKERHUB_PASSWORD", DockerComposeFactoryProperties.get("bamboo.SCDF_ITS_DOCKERHUB_PASSWORD", ""))
109+
.withAdditionalEnvironmentVariable("SCDF_ITS_DOCKERHUB_USER", DockerComposeFactoryProperties.get("bamboo.SCDF_ITS_DOCKERHUB_USER", ""))
110+
.withAdditionalEnvironmentVariable("SCDF_ITS_DOCKERHUB_PASSWORD", DockerComposeFactoryProperties.get("bamboo.SCDF_ITS_DOCKERHUB_PASSWORD", ""))
111111
.withAdditionalEnvironmentVariable("COMPOSE_PROJECT_NAME", "scdf")
112112
.build();
113113

spring-cloud-dataflow-server/src/test/resources/docker-compose-it.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ version: '3'
33
services:
44
dataflow-server:
55
environment:
6-
- SPRING_CLOUD_DATAFLOW_CONTAINER_REGISTRY_CONFIGURATIONS_DEFAULT_USER=${bamboo.SCDF_ITS_DOCKERHUB_USER}
7-
- SPRING_CLOUD_DATAFLOW_CONTAINER_REGISTRY_CONFIGURATIONS_DEFAULT_SECRET=${bamboo.SCDF_ITS_DOCKERHUB_PASSWORD}
6+
- SPRING_CLOUD_DATAFLOW_CONTAINER_REGISTRY_CONFIGURATIONS_DEFAULT_USER=${SCDF_ITS_DOCKERHUB_USER}
7+
- SPRING_CLOUD_DATAFLOW_CONTAINER_REGISTRY_CONFIGURATIONS_DEFAULT_SECRET=${SCDF_ITS_DOCKERHUB_PASSWORD}
88

0 commit comments

Comments
 (0)