Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit b4c3835

Browse files
committed
Revert "Add checksum feature to about controller"
This reverts commit 49de3ab.
1 parent bf07a74 commit b4c3835

File tree

10 files changed

+42
-553
lines changed

10 files changed

+42
-553
lines changed

spring-cloud-dataflow-docs/src/main/asciidoc/configuration.adoc

Lines changed: 10 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,36 +1167,14 @@ then add to the generated Maven pom file the MetricWriter implementation you
11671167
want to use. The documentation on the Data Flow Metrics project pages provides
11681168
the additional information you need to get started.
11691169

1170-
== About Configuration
1171-
The Spring Cloud Data Flow About Restful API result contains a link to the jars
1172-
and the sha1 and or sha256 checksum values for each of the Data Flow components (i.e.
1173-
the Spring Cloud Data Flow Shell). These links are configurable and by default,
1174-
they refer to jars that are stored at Maven Central. However
1175-
since you may be running behind a firewall you may wish to point to a local
1176-
repository. These links are configured via the following properties:
1177-
1178-
* spring.cloud.dataflow.version-info.implementation-url - link to the Spring
1179-
Cloud Data Flow Server-<implementation> (implementation can be
1180-
cloud-foundry, kubernetes, local, etc) jar file.
1181-
* spring.cloud.dataflow.version-info.core-url - link to the Spring Cloud Data
1182-
Flow Core pom.
1183-
* spring.cloud.dataflow.version-info.dashboard-url - link to the Spring Cloud
1184-
Data Flow UI jar.
1185-
* spring.cloud.dataflow.version-info.shell-url - link to the Spring Cloud Data
1186-
Flow Shell jar.
1187-
1188-
There are reserved values (surrounded by curly braces) that you can insert into
1189-
the url that will make sure that the links are up to date:
1190-
1191-
* implementation - inserts the type of Data Flow (Cloud Foundry, Kubernetes, Local, etc).
1192-
* repository - if using a build-snapshot, milestone or release candidate of
1193-
Data Flow, the repository will refer to repo-spring-io repository else it will
1194-
refer to Maven Central.
1195-
* version - Will insert this version of the jar/pom.
1196-
1197-
For example:
1198-
`https://myrepository/org/springframework/cloud/{implementation}/{version}/{implementation}-{version}.jar`
1199-
would produce
1200-
`https://myrepository/org/springframework/cloud/spring-cloud-dataflow-server-local/1.2.3.RELEASE/spring-cloud-dataflow-server-local-1.2.3.RELEASE.jar`
1201-
if you were using the 1.2.3.RELEASE version of the Spring Cloud Data Flow Local Server.
1170+
1171+
1172+
1173+
1174+
1175+
1176+
1177+
1178+
1179+
12021180

spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/resource/about/Dependency.java

Lines changed: 1 addition & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -16,133 +16,43 @@
1616

1717
package org.springframework.cloud.dataflow.rest.resource.about;
1818

19-
import com.fasterxml.jackson.annotation.JsonInclude;
20-
2119
/**
2220
* Holds dependency information of a lbrary used by Spring Cloud Dataflow.
2321
*
2422
* @author Gunnar Hillert
25-
* @author Glenn Renfro
2623
*/
27-
2824
public class Dependency {
2925

3026
private String name;
3127

3228
private String version;
3329

34-
@JsonInclude(JsonInclude.Include.NON_NULL)
35-
private String checksumSha1;
36-
37-
@JsonInclude(JsonInclude.Include.NON_NULL)
38-
private String checksumSha256;
39-
40-
private String url;
41-
4230
/**
4331
* Default constructor for serialization frameworks.
4432
*/
4533
public Dependency() {
4634
}
4735

48-
public Dependency(String name, String version, String checksumsha1,
49-
String checksumsha256, String url) {
36+
public Dependency(String name, String version) {
5037
super();
5138
this.name = name;
5239
this.version = version;
53-
this.checksumSha1 = checksumsha1;
54-
this.checksumSha256 = checksumsha256;
55-
this.url = url;
5640
}
5741

58-
/**
59-
* Retrieve the current name for the {@link Dependency}
60-
61-
* @return the name for the {@link Dependency}
62-
*/
6342
public String getName() {
6443
return name;
6544
}
6645

67-
/**
68-
* Establish the name for the {@link Dependency}.
69-
*
70-
* @param name {@link String} representing the name.
71-
*/
7246
public void setName(String name) {
7347
this.name = name;
7448
}
7549

76-
/**
77-
* Retrieve the current version for the {@link Dependency}
78-
*
79-
* @return the version for the {@link Dependency}
80-
*/
8150
public String getVersion() {
8251
return version;
8352
}
8453

85-
/**
86-
* Establish the version for the {@link Dependency}.
87-
*
88-
* @param version {@link String} representing the version.
89-
*/
9054
public void setVersion(String version) {
9155
this.version = version;
9256
}
9357

94-
/**
95-
* Retrieve the current checksumSha1 for the {@link Dependency}
96-
*
97-
* @return the checksumSha1 for the {@link Dependency}
98-
*/
99-
public String getChecksumSha1() {
100-
return checksumSha1;
101-
}
102-
103-
/**
104-
* Establish the checksumSha1 for the {@link Dependency}.
105-
*
106-
* @param checksumSha1 {@link String} representing the checksumSha1.
107-
*/
108-
public void setChecksumSha1(String checksumSha1)
109-
{
110-
this.checksumSha1 = checksumSha1;
111-
}
112-
113-
/**
114-
* Retrieve the current url for the {@link Dependency}
115-
*
116-
* @return the url for the {@link Dependency}
117-
*/
118-
public String getUrl() {
119-
return url;
120-
}
121-
122-
/**
123-
* Establish the url for the {@link Dependency}.
124-
*
125-
* @param url {@link String} representing the url.
126-
*/
127-
public void setUrl(String url) {
128-
this.url = url;
129-
}
130-
131-
/**
132-
* Retrieve the current checksumSha256 for the {@link Dependency}
133-
*
134-
* @return the checksumSha256 for the {@link Dependency}
135-
*/
136-
public String getChecksumSha256() {
137-
return checksumSha256;
138-
}
139-
140-
/**
141-
* Establish the checksumSha1256 for the {@link Dependency}.
142-
*
143-
* @param checksumSha256 {@link String} representing the checksumSha256.
144-
*/
145-
public void setChecksumSha256(String checksumSha256) {
146-
this.checksumSha256 = checksumSha256;
147-
}
14858
}

spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/resource/about/VersionInfo.java

Lines changed: 15 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -20,93 +20,42 @@
2020
* Provides version information about core libraries used.
2121
*
2222
* @author Gunnar Hillert
23-
* @author Glenn Renfro
2423
*/
2524
public class VersionInfo {
2625

27-
private Dependency implementationDependency = new Dependency();
26+
private Dependency implementation = new Dependency();
2827

29-
private Dependency coreDependency = new Dependency();
28+
private Dependency core = new Dependency();
3029

31-
private Dependency dashboardDependency = new Dependency();
32-
33-
private Dependency shellDependency = new Dependency();
30+
private Dependency dashboard = new Dependency();
3431

3532
/**
3633
* Default constructor for serialization frameworks.
3734
*/
3835
public VersionInfo() {
3936
}
4037

41-
/**
42-
* Retrieves the current {@link Dependency} for the implementation.
43-
*
44-
* @return {@link Dependency} instance containing Implementation information.
45-
*/
46-
public Dependency getImplementationDependency() {
47-
return implementationDependency;
38+
public Dependency getCore() {
39+
return core;
4840
}
4941

50-
/**
51-
* Establish the {@link Dependency} for the implementation.
52-
*
53-
* @param implementationDependency the {@link Dependency} instance for the implementation.
54-
*/
55-
public void setImplementationDependency(Dependency implementationDependency) {
56-
this.implementationDependency = implementationDependency;
42+
public void setCore(Dependency core) {
43+
this.core = core;
5744
}
5845

59-
/**
60-
* Retrieves the current {@link Dependency} for the core Data Flow instance.
61-
*
62-
* @return {@link Dependency} instance containing core Data Flow information.
63-
*/
64-
public Dependency getCoreDependency() {
65-
return coreDependency;
46+
public Dependency getImplementation() {
47+
return implementation;
6648
}
6749

68-
/**
69-
* Establish the {@link Dependency} for the Data Flow core.
70-
*
71-
* @param coreDependency the {@link Dependency} instance for the Data Flow core.
72-
*/
73-
public void setCoreDependency(Dependency coreDependency) {
74-
this.coreDependency = coreDependency;
50+
public void setImplementation(Dependency implementation) {
51+
this.implementation = implementation;
7552
}
7653

77-
/**
78-
* Retrieves the current {@link Dependency} for the Data Flow UI instance.
79-
*
80-
* @return {@link Dependency} instance containing Data Flow UI information.
81-
*/
82-
public Dependency getDashboardDependency() {
83-
return dashboardDependency;
54+
public Dependency getDashboard() {
55+
return dashboard;
8456
}
8557

86-
/**
87-
* Establish the {@link Dependency} for the dashboard.
88-
*
89-
* @param dashboardDependency the {@link Dependency} instance for the dashboard.
90-
*/
91-
public void setDashboardDependency(Dependency dashboardDependency) {
92-
this.dashboardDependency = dashboardDependency;
93-
}
94-
95-
/**
96-
* Retrieves the current {@link Dependency} for the shell instance.
97-
*
98-
* @return {@link Dependency} instance containing shell information.
99-
*/
100-
public Dependency getShellDependency() {
101-
return shellDependency;
102-
}
103-
104-
/**
105-
* Establish the {@link Dependency} for the shell.
106-
*
107-
* @param shellDependency the {@link Dependency} instance for the shell.
108-
*/
109-
public void setShellDependency(Dependency shellDependency) {
110-
this.shellDependency = shellDependency;
58+
public void setDashboard(Dependency dashboard) {
59+
this.dashboard = dashboard;
11160
}
11261
}

0 commit comments

Comments
 (0)