Add role for POST runtime/apps/

Improve logging for StreamDeployerUtil

Author: Corneil du Plessis

spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/stream/StreamDeployerUtil.java

@@ -50,23 +50,19 @@ public static DeploymentState aggregateState(Set<DeploymentState> states) {
 		}
 		DeploymentState result = DeploymentState.partial;
 		if (states.isEmpty() || states.contains(DeploymentState.error)) {
-			logger.debug("aggregateState: Returning " + DeploymentState.error);
 			result = DeploymentState.error;
 		}
 		else if (states.contains(DeploymentState.deployed) && states.contains(DeploymentState.failed)) {
-			logger.debug("aggregateState: Returning " + DeploymentState.partial);
 			result = DeploymentState.partial;
 		}
 		else if (states.contains(DeploymentState.failed)) {
-			logger.debug("aggregateState: Returning " + DeploymentState.failed);
 			result = DeploymentState.failed;
 		}
 		else if (states.contains(DeploymentState.deploying)) {
-			logger.debug("aggregateState: Returning " + DeploymentState.deploying);
 			result = DeploymentState.deploying;
 		}
 
-		logger.debug("aggregateState: Returning " + DeploymentState.partial);
+		logger.debug("aggregateState: Returning " + result);
 		return result;
 	}
 }

spring-cloud-dataflow-server-core/src/main/resources/META-INF/dataflow-server-defaults.yml

@@ -175,6 +175,7 @@ spring:
             - GET    /runtime/streams/**             => hasRole('ROLE_VIEW')
             - GET    /runtime/apps                   => hasRole('ROLE_VIEW')
             - GET    /runtime/apps/**                => hasRole('ROLE_VIEW')
+            - POST   /runtime/apps/**                => hasRole('ROLE_CREATE')
 
             # Schema Versions
             - GET   /schema/versions                 => hasRole('ROLE_VIEW')