Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit ce5565f

Browse files
committed
Fix the task application metrics tag expression
Resolves #4437 Resolves #4299 * fix affected test fixtures. (cherry picked from commit a069fec)
1 parent c408bb6 commit ce5565f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spring-cloud-dataflow-server-core/src/main/resources/META-INF/application-task-common-properties-defaults.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ common:
22
management:
33
metrics:
44
tags:
5-
application: ${task.name:unknown}-${task.execution.id:unknown}
5+
application: ${spring.cloud.task.name:unknown}-${spring.cloud.task.executionid:unknown}
66
service: "task-application"
77

88
local:

spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/TaskSchedulerControllerTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ private void createAndVerifySchedule(String scheduleName, String createdSchedule
210210
"\"taskDefinitionProperties\":{\"management.metrics.tags.service\":\"task-application\"," +
211211
"\"spring.datasource.username\":null,\"spring.datasource.url\":null," +
212212
"\"spring.datasource.driverClassName\":null," +
213-
"\"management.metrics.tags.application\":\"${task.name:unknown}-${task.execution.id:unknown}\"," +
213+
"\"management.metrics.tags.application\":\"${spring.cloud.task.name:unknown}-${spring.cloud.task.executionid:unknown}\"," +
214214
"\"spring.cloud.task.name\":\"testDefinition\"}," +
215215
"\"deploymentProperties\":{}}", auditRecord.getAuditData());
216216
}
@@ -223,7 +223,7 @@ public void testCreateScheduleWithSensitiveFields() throws Exception {
223223
"\"taskDefinitionProperties\":{\"management.metrics.tags.service\":\"task-application\"," +
224224
"\"prop1\":\"foo\",\"spring.datasource.username\":null,\"prop2.secret\":\"******\"," +
225225
"\"spring.datasource.url\":null,\"spring.datasource.driverClassName\":null," +
226-
"\"management.metrics.tags.application\":\"${task.name:unknown}-${task.execution.id:unknown}\"," +
226+
"\"management.metrics.tags.application\":\"${spring.cloud.task.name:unknown}-${spring.cloud.task.executionid:unknown}\"," +
227227
"\"spring.cloud.task.name\":\"testDefinition\"}," +
228228
"\"deploymentProperties\":{\"spring.cloud.deployer.prop1.secret\":\"******\"," +
229229
"\"spring.cloud.deployer.prop2.password\":\"******\"}}",
@@ -239,7 +239,7 @@ public void testCreateScheduleCommaDelimitedArgs() throws Exception {
239239
"\"taskDefinitionProperties\":{\"management.metrics.tags.service\":\"task-application\"," +
240240
"\"prop1\":\"foo\",\"spring.datasource.username\":null,\"prop2.secret\":\"******\"," +
241241
"\"spring.datasource.url\":null,\"spring.datasource.driverClassName\":null," +
242-
"\"management.metrics.tags.application\":\"${task.name:unknown}-${task.execution.id:unknown}\"," +
242+
"\"management.metrics.tags.application\":\"${spring.cloud.task.name:unknown}-${spring.cloud.task.executionid:unknown}\"," +
243243
"\"spring.cloud.task.name\":\"testDefinition\"}," +
244244
"\"deploymentProperties\":{\"spring.cloud.deployer.prop1.secret\":\"******\"," +
245245
"\"spring.cloud.deployer.prop2.password\":\"******\"}}",

0 commit comments

Comments
 (0)