Remove pmd plugin from gradle build

Author: royclarkson

build.gradle

@@ -194,7 +194,6 @@ configure(libraryProjects) {
 
 configure(staticAnalysisProjects) {
 	apply plugin: "checkstyle"
-	apply plugin: "pmd"
 	apply plugin: "jacoco"
 
 	checkstyle {
@@ -207,20 +206,6 @@ configure(staticAnalysisProjects) {
 	checkstyleTest {
 		source = "src/test/java"
 	}
-
-	pmd {
-		consoleOutput = true
-	}
-	pmdMain {
-		ruleSets = []
-		ruleSetFiles = files("${project.rootDir}/src/pmd/pmdRuleSet.xml")
-		source = "src/main/java"
-	}
-	pmdTest {
-		ruleSets = []
-		ruleSetFiles = files("${project.rootDir}/src/pmd/pmdTestRuleSet.xml")
-		source = "src/test/java"
-	}
 }
 
 configure(publishedProjects) {

spring-cloud-app-broker-acceptance-tests/src/test/java/org/springframework/cloud/appbroker/acceptance/BrokerPropertiesParameterResolver.java

@@ -26,14 +26,12 @@
 
 class BrokerPropertiesParameterResolver implements ParameterResolver {
 
-	@SuppressWarnings("PMD.AvoidUncheckedExceptionsInSignatures")
 	@Override
 	public boolean supportsParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
 		throws ParameterResolutionException {
 		return parameterContext.getParameter().getType() == BrokerProperties.class;
 	}
 
-	@SuppressWarnings("PMD.AvoidUncheckedExceptionsInSignatures")
 	@Override
 	public BrokerProperties resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
 		throws ParameterResolutionException {

spring-cloud-app-broker-acceptance-tests/src/test/java/org/springframework/cloud/appbroker/acceptance/CloudFoundryAcceptanceTest.java

@@ -103,7 +103,6 @@
 @ExtendWith(SpringExtension.class)
 @ExtendWith(BrokerPropertiesParameterResolver.class)
 @EnableConfigurationProperties(AcceptanceTestProperties.class)
-@SuppressWarnings("PMD.GodClass")
 abstract class CloudFoundryAcceptanceTest {
 
 	private static final Logger LOG = LoggerFactory.getLogger(CloudFoundryAcceptanceTest.class);

spring-cloud-app-broker-acceptance-tests/src/test/java/org/springframework/cloud/appbroker/acceptance/HealthListener.java

@@ -29,7 +29,6 @@
 import org.springframework.web.client.RestClientException;
 import org.springframework.web.client.RestTemplate;
 
-@SuppressWarnings("PMD.DoNotUseThreads")
 @Service
 class HealthListener {
 

spring-cloud-app-broker-autoconfigure/src/main/java/org/springframework/cloud/appbroker/autoconfigure/AppBrokerAutoConfiguration.java

@@ -73,7 +73,6 @@
 /**
  * App Broker Auto-configuration
  */
-@SuppressWarnings("PMD.CouplingBetweenObjects")
 @Configuration
 @AutoConfigureAfter(CloudFoundryAppDeployerAutoConfiguration.class)
 @ConditionalOnBean(AppDeployer.class)

spring-cloud-app-broker-core/src/main/java/org/springframework/cloud/appbroker/deployer/BackingApplication.java

@@ -29,7 +29,6 @@
 /**
  * An application deployed as part of the service provisioning process
  */
-@SuppressWarnings("PMD.GodClass")
 public class BackingApplication {
 
 	private static final String VALUE_HIDDEN = "<value hidden>";

spring-cloud-app-broker-core/src/main/java/org/springframework/cloud/appbroker/extensions/support/ConfigurationBeanUtils.java

@@ -55,7 +55,7 @@ public static <T> void populate(T targetObject, Map<String, Object> properties)
 		}
 	}
 
-	@SuppressWarnings({"unchecked", "PMD.AvoidCatchingGenericException"})
+	@SuppressWarnings("unchecked")
 	private static <T> T getTargetObject(Object candidate) {
 		try {
 			if (AopUtils.isAopProxy(candidate) && candidate instanceof Advised) {

spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployer.java

@@ -137,7 +137,6 @@
 import org.springframework.http.HttpStatus;
 import org.springframework.util.StringUtils;
 
-@SuppressWarnings({"PMD.GodClass", "PMD.CyclomaticComplexity", "PMD.ExcessiveClassLength"})
 public class CloudFoundryAppDeployer implements AppDeployer, ResourceLoaderAware {
 
 	private static final Duration DEFAULT_PLATFORM_OPERATION_DURATION = Duration.ofMinutes(10);

spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryDeploymentProperties.java

@@ -32,7 +32,7 @@
  * @author Greg Turnquist
  * @author Ilayaperumal Gopinathan
  */
-@SuppressWarnings({"unused", "PMD.TooManyFields"})
+@SuppressWarnings("unused")
 public class CloudFoundryDeploymentProperties extends DeploymentProperties {
 
 	/**

spring-cloud-app-broker-deployer-cloudfoundry/src/test/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployerTest.java

@@ -91,7 +91,7 @@
 import static org.springframework.cloud.appbroker.deployer.DeploymentProperties.TARGET_PROPERTY_KEY;
 import static org.springframework.cloud.appbroker.deployer.cloudfoundry.CloudFoundryDeploymentProperties.DEFAULT_API_POLLING_TIMEOUT_SECONDS;
 
-@SuppressWarnings({"UnassignedFluxMonoInstance", "PMD.ExcessiveClassLength"})
+@SuppressWarnings("UnassignedFluxMonoInstance")
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
 class CloudFoundryAppDeployerTest {