Skip to content

Commit ac78b9b

Browse files
committed
Fix dependencies for the 1.1.x branch
I think we picked up some unintended commits in this branch since the last 1.1.x release tag and accidentally moved to Spring Boot 2.3. Rolling back to the latest available versions in the correct release series: * CF Java Client 4.16.0.RELEASE * Open Service Broker 3.1.2.RELEASE * Spring Boot 2.2.13.RELEASE
1 parent f73f44f commit ac78b9b

File tree

7 files changed

+91
-5
lines changed

7 files changed

+91
-5
lines changed

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ cfJavaClientVersion = 4.16.0.RELEASE
99
checkstyleVersion = 8.33
1010
commonsTextVersion = 1.8
1111
immutablesVersion = 2.8.8
12-
openServiceBrokerVersion = 3.2.0-SNAPSHOT
12+
openServiceBrokerVersion = 3.1.2.RELEASE
1313
pmdVersion = 6.24.0
14-
springBootVersion = 2.3.1.RELEASE
14+
springBootVersion = 2.2.13.RELEASE
1515
springCredhubVersion = 2.1.1.RELEASE
1616
springFrameworkVersion = 5.2.7.RELEASE
1717
wiremockVersion = 2.25.1

spring-cloud-app-broker-deployer-cloudfoundry/src/main/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryDeploymentProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public class CloudFoundryDeploymentProperties extends DeploymentProperties {
114114
/**
115115
* The buildpack to use for deploying the application.
116116
*/
117-
private String buildpack;
117+
private String buildpack = "";
118118

119119
/**
120120
* The type of health check to perform on deployed application, if not overridden per-app. Defaults to PORT

spring-cloud-app-broker-deployer-cloudfoundry/src/test/java/org/springframework/cloud/appbroker/deployer/cloudfoundry/CloudFoundryAppDeployerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ class CloudFoundryAppDeployerTest {
151151
@BeforeEach
152152
void setUp() {
153153
deploymentProperties = new CloudFoundryDeploymentProperties();
154+
154155
CloudFoundryTargetProperties targetProperties = new CloudFoundryTargetProperties();
155156
targetProperties.setDefaultOrg("default-org");
156157
targetProperties.setDefaultSpace("default-space");
@@ -190,6 +191,7 @@ void deployAppWithPlatformDefaults() {
190191
ApplicationManifest expectedManifest = baseManifestWithSpringAppJson()
191192
.name(APP_NAME)
192193
.path(new File(APP_PATH).toPath())
194+
.buildpacks("") // Empty list means to discover the buildpack
193195
.build();
194196

195197
then(operationsApplications).should().pushManifest(argThat(matchesManifest(expectedManifest)));
@@ -433,6 +435,7 @@ void deployAppWithEnvironmentUsingSpringAppJson() {
433435
"\"ENV_VAR_2\":\"value2\",\"ENV_VAR_1\":\"value1\"")
434436
.name(APP_NAME)
435437
.path(new File(APP_PATH).toPath())
438+
.buildpacks("")
436439
.environmentVariable("JAVA_OPTS", "-Xms512m -Xmx1024m")
437440
.build();
438441

@@ -459,6 +462,7 @@ void deployAppWithEnvironmentNotUsingSpringAppJson() {
459462
ApplicationManifest expectedManifest = baseManifest()
460463
.name(APP_NAME)
461464
.path(new File(APP_PATH).toPath())
465+
.buildpack("")
462466
.environmentVariable("JAVA_OPTS", "-Xms512m -Xmx1024m")
463467
.environmentVariable("spring.cloud.appbroker.service-instance-id", SERVICE_INSTANCE_ID)
464468
.environmentVariable("ENV_VAR_1", "value1")

spring-cloud-app-broker-docs/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ dependencies {
2929
implementation enforcedPlatform("org.springframework.boot:spring-boot-dependencies:${springBootVersion}")
3030
implementation project(":spring-cloud-app-broker-core")
3131
implementation "org.springframework.boot:spring-boot-starter"
32-
implementation "org.springframework.boot:spring-boot-starter-data-r2dbc"
3332
implementation "org.springframework.boot:spring-boot-starter-security"
3433
implementation "org.springframework.boot:spring-boot-starter-tomcat"
3534
implementation "io.projectreactor:reactor-core"
3635
implementation "io.r2dbc:r2dbc-h2:0.8.0.RELEASE"
36+
implementation "org.springframework.data:spring-data-r2dbc:1.1.9.RELEASE"
3737

3838
docs "io.spring.docresources:spring-doc-resources:0.2.1.RELEASE@zip"
3939
}

spring-cloud-app-broker-integration-tests/src/test/java/org/springframework/cloud/appbroker/integration/WiremockComponentTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"spring.cloud.appbroker.deployer.cloudfoundry.password=adminpass",
5151
"spring.cloud.appbroker.deployer.cloudfoundry.default-org=test",
5252
"spring.cloud.appbroker.deployer.cloudfoundry.default-space=development",
53-
"spring.cloud.appbroker.deployer.cloudfoundry.secure=false"
53+
"spring.cloud.appbroker.deployer.cloudfoundry.secure=false",
54+
"spring.cloud.appbroker.deployer.cloudfoundry.properties.buildpack=example-buildpack"
5455
}
5556
)
5657
@ActiveProfiles("openservicebroker-catalog")

spring-cloud-app-broker-integration-tests/src/test/java/org/springframework/cloud/appbroker/integration/fixtures/CloudControllerStubFixture.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ public void stubPushAppWithHost(final String appName, final String host, Content
236236
}
237237

238238
public void stubUpdateAppWithUpgrade(final String appName) {
239+
stubGetV3App(appName);
239240
stubUpdateEnvironment(appName);
240241
stubCreatePackage(appName);
241242
stubCreateBuild(appName);
@@ -248,12 +249,22 @@ public void stubUpdateAppWithHostAndDomain(final String appName) {
248249
}
249250

250251
public void stubUpdateApp(final String appName) {
252+
stubGetV3App(appName);
251253
stubUpdateEnvironment(appName);
252254
stubGetPackage(appName);
253255
stubCreateBuild(appName);
254256
stubCreateDeployment(appName);
255257
}
256258

259+
private void stubGetV3App(String appName) {
260+
stubFor(get(urlPathEqualTo("/v3/apps/" + appGuid(appName)))
261+
.willReturn(ok()
262+
.withBody(cc("get-v3-app-STARTED",
263+
replace("@name", appName),
264+
replace("@guid", appGuid(appName))
265+
))));
266+
}
267+
257268
private void stubAppAfterCreation(String appName, String host) {
258269
stubMapRouteToApp(appName, host);
259270
stubUploadAppBits(appName);
Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
{
2+
"guid": "@guid",
3+
"name": "@name",
4+
"state": "STARTED",
5+
"created_at": "2016-03-17T21:41:30Z",
6+
"updated_at": "2016-06-08T16:41:26Z",
7+
"lifecycle": {
8+
"type": "buildpack",
9+
"data": {
10+
"buildpacks": [
11+
"java_buildpack"
12+
],
13+
"stack": "cflinuxfs3"
14+
}
15+
},
16+
"relationships": {
17+
"space": {
18+
"data": {
19+
"guid": "@space-guid"
20+
}
21+
}
22+
},
23+
"links": {
24+
"self": {
25+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446"
26+
},
27+
"space": {
28+
"href": "https://api.example.org/v3/spaces/2f35885d-0c9d-4423-83ad-fd05066f8576"
29+
},
30+
"processes": {
31+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/processes"
32+
},
33+
"packages": {
34+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/packages"
35+
},
36+
"environment_variables": {
37+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/environment_variables"
38+
},
39+
"current_droplet": {
40+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/droplets/current"
41+
},
42+
"droplets": {
43+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/droplets"
44+
},
45+
"tasks": {
46+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/tasks"
47+
},
48+
"start": {
49+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/actions/start",
50+
"method": "POST"
51+
},
52+
"stop": {
53+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/actions/stop",
54+
"method": "POST"
55+
},
56+
"revisions": {
57+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/revisions"
58+
},
59+
"deployed_revisions": {
60+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/revisions/deployed"
61+
},
62+
"features": {
63+
"href": "https://api.example.org/v3/apps/1cb006ee-fb05-47e1-b541-c34179ddc446/features"
64+
}
65+
},
66+
"metadata": {
67+
"labels": {},
68+
"annotations": {}
69+
}
70+
}

0 commit comments

Comments
 (0)