Skip to content

Commit 941747d

Browse files
committed
Fix tests.
1 parent 84babc1 commit 941747d

File tree

2 files changed

+47
-12
lines changed

2 files changed

+47
-12
lines changed

spring-cloud-commons/src/test/java/org/springframework/cloud/client/loadbalancer/LoadBalancedRestClientIntegrationTests.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.springframework.boot.SpringBootConfiguration;
2525
import org.springframework.boot.test.context.SpringBootTest;
2626
import org.springframework.cloud.client.ServiceInstance;
27-
import org.springframework.context.ApplicationContext;
2827
import org.springframework.context.annotation.Bean;
2928
import org.springframework.web.client.RestClient;
3029

@@ -40,17 +39,17 @@
4039
properties = "spring.cloud.loadbalancer.retry.enabled=false")
4140
public class LoadBalancedRestClientIntegrationTests {
4241

43-
private final RestClient client;
42+
private final RestClient.Builder restClientBuilder;
4443

45-
@Autowired
46-
ApplicationContext context;
4744

48-
public LoadBalancedRestClientIntegrationTests(@Autowired RestClient.Builder clientBuilder) {
49-
this.client = clientBuilder.build();
45+
public LoadBalancedRestClientIntegrationTests(@Autowired RestClient.Builder restClientBuilder) {
46+
this.restClientBuilder = restClientBuilder;
5047
}
5148

5249
@Test
5350
void shouldBuildLoadBalancedRestClientInConstructor() {
51+
RestClient client = restClientBuilder.build();
52+
5453
// Interceptors are not visible in RestClient
5554
assertThatThrownBy(() -> client.get().uri("http://test-service").retrieve())
5655
.hasMessage("LoadBalancerInterceptor invoked.");

spring-cloud-commons/src/test/java/org/springframework/cloud/client/loadbalancer/LoadBalancedRestTemplateBuilderIntegrationTests.java

Lines changed: 42 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616

1717
package org.springframework.cloud.client.loadbalancer;
1818

19+
import java.net.URI;
20+
1921
import org.junit.jupiter.api.Test;
2022

2123
import org.springframework.beans.factory.annotation.Autowired;
2224
import org.springframework.boot.SpringBootConfiguration;
2325
import org.springframework.boot.test.context.SpringBootTest;
2426
import org.springframework.boot.web.client.RestTemplateBuilder;
25-
import org.springframework.context.ApplicationContext;
27+
import org.springframework.cloud.client.ServiceInstance;
2628
import org.springframework.context.annotation.Bean;
2729
import org.springframework.web.client.RestTemplate;
2830

@@ -39,9 +41,6 @@ public class LoadBalancedRestTemplateBuilderIntegrationTests {
3941

4042
private final RestTemplateBuilder restTemplateBuilder;
4143

42-
@Autowired
43-
ApplicationContext context;
44-
4544
public LoadBalancedRestTemplateBuilderIntegrationTests(@Autowired RestTemplateBuilder restTemplateBuilder) {
4645
this.restTemplateBuilder = restTemplateBuilder;
4746
}
@@ -51,7 +50,12 @@ void shouldBuildLoadBalancedRestTemplate() {
5150
RestTemplate restTemplate = restTemplateBuilder.build();
5251

5352
assertThat(restTemplate.getInterceptors()).hasSize(1);
54-
assertThat(restTemplate.getInterceptors().get(0)).isInstanceOf(BlockingLoadBalancerInterceptor.class);
53+
assertThat(restTemplate.getInterceptors()
54+
.get(0)).isInstanceOf(DeferringLoadBalancerInterceptor.class);
55+
assertThat(((DeferringLoadBalancerInterceptor) restTemplate.getInterceptors()
56+
.get(0))
57+
.getLoadBalancerInterceptorProvider()
58+
.getObject()).isInstanceOf(BlockingLoadBalancerInterceptor.class);
5559
}
5660

5761
@SpringBootConfiguration
@@ -63,6 +67,38 @@ RestTemplateBuilder restTemplateBuilder() {
6367
return new RestTemplateBuilder();
6468
}
6569

70+
@Bean
71+
LoadBalancerClient testLoadBalancerClient() {
72+
return new LoadBalancerClient() {
73+
@Override
74+
public <T> T execute(String serviceId, LoadBalancerRequest<T> request) {
75+
throw new UnsupportedOperationException("LoadBalancerInterceptor invoked.");
76+
}
77+
78+
@Override
79+
public <T> T execute(String serviceId, ServiceInstance serviceInstance,
80+
LoadBalancerRequest<T> request) {
81+
throw new UnsupportedOperationException("LoadBalancerInterceptor invoked.");
82+
}
83+
84+
@Override
85+
public URI reconstructURI(ServiceInstance instance, URI original) {
86+
throw new UnsupportedOperationException("LoadBalancerInterceptor invoked.");
87+
}
88+
89+
@Override
90+
public ServiceInstance choose(String serviceId) {
91+
throw new UnsupportedOperationException("LoadBalancerInterceptor invoked.");
92+
}
93+
94+
@Override
95+
public <T> ServiceInstance choose(String serviceId, Request<T> request) {
96+
throw new UnsupportedOperationException("LoadBalancerInterceptor invoked.");
97+
}
98+
};
99+
}
100+
101+
}
102+
66103
}
67104

68-
}

0 commit comments

Comments
 (0)